Verschiedene Bug Fixes.

git-svn-id: https://svn.libreccm.org/ccm/trunk@1299 8810af33-2d31-482b-a856-94f89814c4df
master
jensp 2011-11-25 20:32:55 +00:00
parent 3cc4bdba14
commit 42694b6dad
8 changed files with 47 additions and 27 deletions

View File

@ -66,7 +66,7 @@ public class GreetingItem extends AbstractComponent {
return null; return null;
} }
if (!ContentItem.VERSION.equals(item.getVersion())) { if (!ContentItem.LIVE.equals(item.getVersion())) {
item = item.getLiveVersion(); item = item.getLiveVersion();
} }

View File

@ -172,7 +172,7 @@ public class SciDepartmentProjectsTab implements GenericOrgaUnitTab {
subDepartmentsQuery.setParameter("orgaunitId", subDepartmentsQuery.setParameter("orgaunitId",
orgaunit.getID().toString()); orgaunit.getID().toString());
subDepartmentsQuery.setParameter("assocType", subDepartmentsQuery.setParameter("assocType",
SciDepartmentProjectsStep.ASSOC_TYPE); SciDepartmentSubDepartmentsStep.ASSOC_TYPE);
while (subDepartmentsQuery.next()) { while (subDepartmentsQuery.next()) {
/*if (projectsFilter.length() > 0) { /*if (projectsFilter.length() > 0) {

View File

@ -112,7 +112,7 @@ public class SciDepartmentPublicationsTab implements GenericOrgaUnitTab {
depPublicationsElem.newChildElement("greeting"); depPublicationsElem.newChildElement("greeting");
publications.addOrder("year"); publications.addOrder("year desc");
if (config.getOneRowPerAuthor()) { if (config.getOneRowPerAuthor()) {
publications.addOrder("surname"); publications.addOrder("surname");
} else { } else {
@ -172,6 +172,7 @@ public class SciDepartmentPublicationsTab implements GenericOrgaUnitTab {
publications.addOrder("year asc"); publications.addOrder("year asc");
}*/ }*/
publications.addOrder("year desc");
if (config.getOneRowPerAuthor()) { if (config.getOneRowPerAuthor()) {
publications.addOrder("surname"); publications.addOrder("surname");
publications.addOrder("title"); publications.addOrder("title");
@ -180,7 +181,7 @@ public class SciDepartmentPublicationsTab implements GenericOrgaUnitTab {
publications.addOrder("title"); publications.addOrder("title");
} }
yearFilter.setDataQuery(publications, "year"); yearFilter.setDataQuery(getData(orgaunit), "year");
applyYearFilter(publications, request); applyYearFilter(publications, request);
applyTitleFilter(publications, request); applyTitleFilter(publications, request);
@ -351,7 +352,7 @@ public class SciDepartmentPublicationsTab implements GenericOrgaUnitTab {
final long start = System.currentTimeMillis(); final long start = System.currentTimeMillis();
final XmlGenerator generator = new XmlGenerator(publication); final XmlGenerator generator = new XmlGenerator(publication);
generator.setUseExtraXml(false); generator.setUseExtraXml(false);
generator.setItemElemName("publication", ""); generator.setItemElemName("publications", "");
generator.generateXML(state, parent, ""); generator.generateXML(state, parent, "");
logger.debug(String.format( logger.debug(String.format(
"Generated XML for publication '%s' in %d ms.", "Generated XML for publication '%s' in %d ms.",

View File

@ -175,7 +175,7 @@ public class SciInstituteProjectsTab implements GenericOrgaUnitTab {
subDepartmentsQuery.setParameter("orgaunitId", subDepartmentsQuery.setParameter("orgaunitId",
orgaunit.getID().toString()); orgaunit.getID().toString());
subDepartmentsQuery.setParameter("assocType", subDepartmentsQuery.setParameter("assocType",
SciInstituteProjectsStep.ASSOC_TYPE); SciInstituteDepartmentsStep.ASSOC_TYPE);
while (subDepartmentsQuery.next()) { while (subDepartmentsQuery.next()) {
/*if (projectsFilter.length() > 0) { /*if (projectsFilter.length() > 0) {

View File

@ -138,7 +138,7 @@ public class SciInstitutePublicationsTab implements GenericOrgaUnitTab {
publicationsElem.newChildElement("greeting"); publicationsElem.newChildElement("greeting");
publications.addOrder("year"); publications.addOrder("year desc");
if (config.getOneRowPerAuthor()) { if (config.getOneRowPerAuthor()) {
publications.addOrder("surname"); publications.addOrder("surname");
} else { } else {
@ -374,7 +374,7 @@ public class SciInstitutePublicationsTab implements GenericOrgaUnitTab {
final long start = System.currentTimeMillis(); final long start = System.currentTimeMillis();
final XmlGenerator generator = new XmlGenerator(publication); final XmlGenerator generator = new XmlGenerator(publication);
generator.setUseExtraXml(false); generator.setUseExtraXml(false);
generator.setItemElemName("publication", ""); generator.setItemElemName("publications", "");
generator.generateXML(state, parent, ""); generator.generateXML(state, parent, "");
logger.debug(String.format( logger.debug(String.format(
"Generated XML for publication '%s' in %d ms.", "Generated XML for publication '%s' in %d ms.",

View File

@ -55,7 +55,9 @@ public class SciInstituteSummaryTab implements GenericOrgaUnitTab {
generateHeadOfInstituteXml(institute, instituteSummaryElem, state); generateHeadOfInstituteXml(institute, instituteSummaryElem, state);
} }
if (config.isShowingDepartments()) {
generateDepartmentsXml(institute, instituteSummaryElem, state); generateDepartmentsXml(institute, instituteSummaryElem, state);
}
logger.debug(String.format("Generated XML for summary tab of institute " logger.debug(String.format("Generated XML for summary tab of institute "
+ "'%s' in %d ms.", + "'%s' in %d ms.",

View File

@ -15,6 +15,7 @@ public class SciInstituteSummaryTabConfig extends AbstractConfig {
private final Parameter showHeads; private final Parameter showHeads;
private final Parameter headRole; private final Parameter headRole;
private final Parameter activeStatus; private final Parameter activeStatus;
private final Parameter showDepartments;
public SciInstituteSummaryTabConfig() { public SciInstituteSummaryTabConfig() {
showHeads = showHeads =
@ -35,9 +36,16 @@ public class SciInstituteSummaryTabConfig extends AbstractConfig {
Parameter.REQUIRED, Parameter.REQUIRED,
"active"); "active");
showDepartments =
new BooleanParameter(
"com.arsdigita.cms.contenttypes.sciinstitute.summarytab.departments.show",
Parameter.REQUIRED,
true);
register(showHeads); register(showHeads);
register(headRole); register(headRole);
register(activeStatus); register(activeStatus);
register(showDepartments);
loadInfo(); loadInfo();
} }
@ -53,4 +61,8 @@ public class SciInstituteSummaryTabConfig extends AbstractConfig {
public final String getActiveStatus() { public final String getActiveStatus() {
return (String) get(activeStatus); return (String) get(activeStatus);
} }
public final Boolean isShowingDepartments() {
return (Boolean) get(showDepartments);
}
} }

View File

@ -3,12 +3,17 @@ com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.show.purpose = Show
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.show.example = true com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.show.example = true
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.show.format = [Boolean] com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.show.format = [Boolean]
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role = Role of the heads of the institute com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role.title = Role of the heads of the institute
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role = Role of the heads of the institute. This is an attribute of the association between GenericOrganizationalUnit and GenericPerson. This value may contains more than value, separated by ','. com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role.purpose = Role of the heads of the institute. This is an attribute of the association between GenericOrganizationalUnit and GenericPerson. This value may contains more than value, separated by ','.
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role = active,heading com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role.example = active,heading
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role = [String] com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.role.format = [String]
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active = Status of active members com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active.title = Status of active members
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active = Status of the active members of the institute. Used to filter out former heads. This is an attribute of the association between GenericOrganizationalUnit and GenericPerson. This value may contains more than value, separated by ','. com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active.purpose = Status of the active members of the institute. Used to filter out former heads. This is an attribute of the association between GenericOrganizationalUnit and GenericPerson. This value may contains more than value, separated by ','.
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active = former,formerHead com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active.example = former,formerHead
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active = [String] com.arsdigita.cms.contenttypes.sciinstitute.summarytab.heads.status.active.format = [String]
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.departments.show.title = Show departments?
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.departments.show.purpose = Show departments?
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.departments.show.example = true
com.arsdigita.cms.contenttypes.sciinstitute.summarytab.departments.show.format = [Boolean]