diff --git a/ccm-core/src/com/arsdigita/ui/UserBanner.java b/ccm-core/src/com/arsdigita/ui/UserBanner.java index db50c9022..8bd6c7c9a 100755 --- a/ccm-core/src/com/arsdigita/ui/UserBanner.java +++ b/ccm-core/src/com/arsdigita/ui/UserBanner.java @@ -62,6 +62,7 @@ public class UserBanner extends SimpleComponent { * @param state * @param parent */ + @Override public void generateXML(PageState state, Element parent) { init(); diff --git a/ccm-core/src/com/arsdigita/web/RedirectSignal.java b/ccm-core/src/com/arsdigita/web/RedirectSignal.java index 1ba63bd9e..40aab62a8 100755 --- a/ccm-core/src/com/arsdigita/web/RedirectSignal.java +++ b/ccm-core/src/com/arsdigita/web/RedirectSignal.java @@ -22,14 +22,14 @@ import com.arsdigita.util.Assert; import org.apache.log4j.Logger; /** - *

A signal that requests to commit or abort the current transaction - * and to send a redirect to a new URL. BaseServlet traps this signal - * when it is thrown and finishes the transaction before it sends the - * redirect to the response. This way the client cannot see state - * inconsistent with work performed in the previous request.

+ *

A signal that requests to commit or abort the current transaction and to + * send a redirect to a new URL. BaseServlet traps this signal when it is thrown + * and finishes the transaction before it sends the redirect to the response. + * This way the client cannot see state inconsistent with work performed in the + * previous request.

* - *

RedirectSignals are usually sent after doing work - * on behalf of the user:

+ *

RedirectSignals are usually sent after doing work on behalf + * of the user:

* *
  * private final void saveUserSettings(final HttpServletRequest sreq) {
@@ -52,10 +52,18 @@ import org.apache.log4j.Logger;
  */
 public class RedirectSignal extends TransactionSignal {
 
+    /** Logger instance for debugging support.                               */
     private static final Logger s_log = Logger.getLogger(RedirectSignal.class);
 
+    /** Destination URL where redirect to                                    */
     private final String m_url;
 
+    /**
+     * Constructor 
+     * 
+     * @param url
+     * @param isCommitRequested
+     */
     public RedirectSignal(final String url, final boolean isCommitRequested) {
         super(isCommitRequested);
 
@@ -75,6 +83,12 @@ public class RedirectSignal extends TransactionSignal {
         m_url = url;
     }
 
+    /**
+     * Convenience Constructor for URL objects.
+     * 
+     * @param url
+     * @param isCommitRequested
+     */
     public RedirectSignal(final URL url, final boolean isCommitRequested) {
         this(url.toString(), isCommitRequested);
     }
diff --git a/ccm-core/src/com/arsdigita/web/URL.java b/ccm-core/src/com/arsdigita/web/URL.java
index dc7383591..6a407c78e 100755
--- a/ccm-core/src/com/arsdigita/web/URL.java
+++ b/ccm-core/src/com/arsdigita/web/URL.java
@@ -853,7 +853,7 @@ public class URL {
         return URL.there(sreq, app, pathInfo);
     }
 
-    public static final URL excursion(final HttpServletRequest sreq,
+    public static URL excursion(final HttpServletRequest sreq,
                                       final String path,
                                       final ParameterMap params) {
         if (s_log.isDebugEnabled()) {
@@ -867,7 +867,7 @@ public class URL {
         return url;
     }
 
-    public final URL excursion(final HttpServletRequest sreq,
+    public static URL excursion(final HttpServletRequest sreq,
                                       final String path) {
         return URL.excursion(sreq, path, new ParameterMap());
     }