From bbff4ab565066ec99f0562914cafc274bf4e5103 Mon Sep 17 00:00:00 2001 From: pb Date: Sat, 9 Feb 2013 14:56:44 +0000 Subject: [PATCH] Removed unused code, removed user themeing capabilities, added documentation, improved code structure. Update Script required (not yet provided). git-svn-id: https://svn.libreccm.org/ccm/trunk@2062 8810af33-2d31-482b-a856-94f89814c4df --- ccm-portalworkspace/application.xml | 2 +- .../portlets}/MyWorkspacesPortlet.java | 0 .../doc/unsupported/portlets/README | 22 + .../portlets}/WorkspaceNavigatorPortlet.java | 0 .../portlets}/WorkspaceSummaryPortlet.java | 0 .../unsupported}/ui/WorkspaceTheme.java | 0 .../unsupported/ui}/WorkspaceTheme.pdl | 0 .../ui/WorkspaceThemeCollection.java | 0 .../unsupported}/ui/WorkspaceThemes.java | 0 .../arsdigita/portalworkspace/Workspace.pdl | 4 +- .../src/ccm-portalworkspace.upgrade | 4 + .../portalworkspace/Initializer.java | 39 -- .../com/arsdigita/portalworkspace/Loader.java | 30 +- .../arsdigita/portalworkspace/PageLayout.java | 5 +- .../StatefulPersistentPortal.java | 20 +- .../StatefulPersistentPortalModelBuilder.java | 24 +- .../portalworkspace/StatefulPortlet.java | 4 +- .../arsdigita/portalworkspace/Workspace.java | 26 +- .../portalworkspace/WorkspacePage.java | 29 +- .../ui/AbstractWorkspaceComponent.java | 7 +- .../ui/ApplicationPortlet.java | 6 +- .../portalworkspace/ui/LayoutForm.java | 2 +- .../portalworkspace/ui/PersistentPortal.java | 8 +- .../portalworkspace/ui/PortalConstants.java | 35 -- .../portalworkspace/ui/PortalEditForm.java | 2 +- .../ui/PortalEditModelBuilder.java | 4 +- .../portalworkspace/ui/PortalList.java | 4 +- .../portalworkspace/ui/SimplePortlet.java | 3 +- .../ui/WorkspaceComponent.java | 6 +- .../portalworkspace/ui/WorkspaceDetails.java | 4 +- .../portalworkspace/ui/WorkspaceEditor.java | 479 ------------------ .../portalworkspace/ui/admin/AdminPane.java | 38 +- .../ui/admin/ApplicationDetails.java | 10 +- .../ui/admin/ApplicationList.java | 15 +- .../ui/admin/ApplicationPane.java | 8 +- .../ui/admin/ApplicationSelectionModel.java | 5 +- .../ui/admin/CategoryComponent.java | 20 +- .../ui/admin/DeleteApplicationComponent.java | 4 +- .../ui/admin/NewApplicationForm.java | 4 +- .../portalworkspace/ui/admin/PeoplePane.java | 15 +- .../portalworkspace/ui/admin/SiteMapPane.java | 15 +- .../ui/{ => jsp}/DefaultWorkspace.java | 10 +- .../DefaultWorkspaceSelectionModel.java | 3 +- .../ui/{ => jsp}/PackageWorkspace.java | 4 +- .../PackageWorkspaceSelectionModel.java | 3 +- .../ui/jsp/WorkspaceEditor.java | 244 +++++++++ .../ui/{ => jsp}/WorkspaceViewer.java | 24 +- .../{ => personalws}/PersonalPortalPage.java | 2 +- .../ui/{ => personalws}/UserWorkspace.java | 4 +- .../UserWorkspaceSelectionModel.java | 3 +- .../ApplicationDirectoryPortletRenderer.java | 6 +- .../ContentDirectoryPortletRenderer.java | 6 +- .../ui/portlet/FlashPortletRenderer.java | 12 +- .../portlet/FreeformHTMLPortletRenderer.java | 4 +- .../ui/portlet/LoginPortletRenderer.java | 8 +- .../ui/portlet/RSSFeedPortletRenderer.java | 6 +- .../ccm-portalworkspace/admin/edit.jsp | 7 +- .../ccm-portalworkspace/admin/index.jsp | 6 +- .../ccm-portalworkspace/admin/sitemap.jsp | 6 +- .../templates/ccm-portalworkspace/edit.jsp | 4 +- .../templates/ccm-portalworkspace/index.jsp | 6 +- .../navigation/portal-categorized.jsp | 37 ++ 62 files changed, 553 insertions(+), 755 deletions(-) rename ccm-portalworkspace/{src/com/arsdigita/portalworkspace/portlet => doc/unsupported/portlets}/MyWorkspacesPortlet.java (100%) create mode 100644 ccm-portalworkspace/doc/unsupported/portlets/README rename ccm-portalworkspace/{src/com/arsdigita/portalworkspace/portlet => doc/unsupported/portlets}/WorkspaceNavigatorPortlet.java (100%) rename ccm-portalworkspace/{src/com/arsdigita/portalworkspace/portlet => doc/unsupported/portlets}/WorkspaceSummaryPortlet.java (100%) rename ccm-portalworkspace/{src/com/arsdigita/portalworkspace => doc/unsupported}/ui/WorkspaceTheme.java (100%) rename ccm-portalworkspace/{pdl/com/arsdigita/portalworkspace => doc/unsupported/ui}/WorkspaceTheme.pdl (100%) rename ccm-portalworkspace/{src/com/arsdigita/portalworkspace => doc/unsupported}/ui/WorkspaceThemeCollection.java (100%) rename ccm-portalworkspace/{src/com/arsdigita/portalworkspace => doc/unsupported}/ui/WorkspaceThemes.java (100%) delete mode 100755 ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/PortalConstants.java delete mode 100755 ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/WorkspaceEditor.java rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => jsp}/DefaultWorkspace.java (94%) rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => jsp}/DefaultWorkspaceSelectionModel.java (94%) rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => jsp}/PackageWorkspace.java (96%) rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => jsp}/PackageWorkspaceSelectionModel.java (91%) create mode 100755 ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/jsp/WorkspaceEditor.java rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => jsp}/WorkspaceViewer.java (74%) rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => personalws}/PersonalPortalPage.java (99%) rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => personalws}/UserWorkspace.java (92%) rename ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/{ => personalws}/UserWorkspaceSelectionModel.java (93%) create mode 100644 ccm-portalworkspace/web/templates/ccm-portalworkspace/navigation/portal-categorized.jsp diff --git a/ccm-portalworkspace/application.xml b/ccm-portalworkspace/application.xml index d6c98c45f..c4ecb0572 100755 --- a/ccm-portalworkspace/application.xml +++ b/ccm-portalworkspace/application.xml @@ -2,7 +2,7 @@ diff --git a/ccm-portalworkspace/src/com/arsdigita/portalworkspace/portlet/MyWorkspacesPortlet.java b/ccm-portalworkspace/doc/unsupported/portlets/MyWorkspacesPortlet.java similarity index 100% rename from ccm-portalworkspace/src/com/arsdigita/portalworkspace/portlet/MyWorkspacesPortlet.java rename to ccm-portalworkspace/doc/unsupported/portlets/MyWorkspacesPortlet.java diff --git a/ccm-portalworkspace/doc/unsupported/portlets/README b/ccm-portalworkspace/doc/unsupported/portlets/README new file mode 100644 index 000000000..e9c23967d --- /dev/null +++ b/ccm-portalworkspace/doc/unsupported/portlets/README @@ -0,0 +1,22 @@ +MyWorkspacePortlet: + Code is broken and aborts program flow unrecoverable. + No documentation at all, seems to create a list of personaƶ Workspaces. + Not usefule for PortalWorkspace, as it is meant as a system wide frontpage + or as leaf for navigation. No option for personal homepages here. + May be useful for PortalServer and its personal homepages. + +WorkspaceNavigatorPortlet + Code is broken, no documentation at all. Seems to provide a list of child + Workspaces and related Workspaces. Not useful for PortalWorkspace because + it is not meant to form a interwoven system of portal pages. + Portlet of the same name is part of PortalServer where it should be useful. + +WorkspaceSummaryPortlet + Code is broken, no documentation at all. Seems to provide a list of objects, + probably participants. + +All 3 portlets have internal classes to provide a PortletRenderer. XML files +are missing, but the tags may be part of the PortalWorkspace applications XML. +Not checked. + + diff --git a/ccm-portalworkspace/src/com/arsdigita/portalworkspace/portlet/WorkspaceNavigatorPortlet.java b/ccm-portalworkspace/doc/unsupported/portlets/WorkspaceNavigatorPortlet.java similarity index 100% rename from ccm-portalworkspace/src/com/arsdigita/portalworkspace/portlet/WorkspaceNavigatorPortlet.java rename to ccm-portalworkspace/doc/unsupported/portlets/WorkspaceNavigatorPortlet.java diff --git a/ccm-portalworkspace/src/com/arsdigita/portalworkspace/portlet/WorkspaceSummaryPortlet.java b/ccm-portalworkspace/doc/unsupported/portlets/WorkspaceSummaryPortlet.java similarity index 100% rename from ccm-portalworkspace/src/com/arsdigita/portalworkspace/portlet/WorkspaceSummaryPortlet.java rename to ccm-portalworkspace/doc/unsupported/portlets/WorkspaceSummaryPortlet.java diff --git a/ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/WorkspaceTheme.java b/ccm-portalworkspace/doc/unsupported/ui/WorkspaceTheme.java similarity index 100% rename from ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/WorkspaceTheme.java rename to ccm-portalworkspace/doc/unsupported/ui/WorkspaceTheme.java diff --git a/ccm-portalworkspace/pdl/com/arsdigita/portalworkspace/WorkspaceTheme.pdl b/ccm-portalworkspace/doc/unsupported/ui/WorkspaceTheme.pdl similarity index 100% rename from ccm-portalworkspace/pdl/com/arsdigita/portalworkspace/WorkspaceTheme.pdl rename to ccm-portalworkspace/doc/unsupported/ui/WorkspaceTheme.pdl diff --git a/ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/WorkspaceThemeCollection.java b/ccm-portalworkspace/doc/unsupported/ui/WorkspaceThemeCollection.java similarity index 100% rename from ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/WorkspaceThemeCollection.java rename to ccm-portalworkspace/doc/unsupported/ui/WorkspaceThemeCollection.java diff --git a/ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/WorkspaceThemes.java b/ccm-portalworkspace/doc/unsupported/ui/WorkspaceThemes.java similarity index 100% rename from ccm-portalworkspace/src/com/arsdigita/portalworkspace/ui/WorkspaceThemes.java rename to ccm-portalworkspace/doc/unsupported/ui/WorkspaceThemes.java diff --git a/ccm-portalworkspace/pdl/com/arsdigita/portalworkspace/Workspace.pdl b/ccm-portalworkspace/pdl/com/arsdigita/portalworkspace/Workspace.pdl index 40b7c71d4..2cde44a19 100755 --- a/ccm-portalworkspace/pdl/com/arsdigita/portalworkspace/Workspace.pdl +++ b/ccm-portalworkspace/pdl/com/arsdigita/portalworkspace/Workspace.pdl @@ -24,7 +24,7 @@ object type Workspace extends Application { to pw_workspace_pages.workspace_id; PageLayout[1..1] defaultLayout = join pw_workspaces.default_layout_id to pw_workspace_page_layouts.layout_id; - WorkspaceTheme[0..1] theme = join pw_workspaces.theme_id to pw_workspace_themes.theme_id; + // WorkspaceTheme[0..1] theme = join pw_workspaces.theme_id to pw_workspace_themes.theme_id; User[0..1] owner = join pw_workspaces.owner_id to users.user_id; Workspace[0..n] relatedWorkspace = @@ -55,7 +55,7 @@ query childWorkspacesForApplicationID { acs_objects.display_name, acs_objects.default_domain_class, applications.parent_application_id, - applications.package_id, + // applications.package_id, applications.title, applications.primary_url, applications.description diff --git a/ccm-portalworkspace/src/ccm-portalworkspace.upgrade b/ccm-portalworkspace/src/ccm-portalworkspace.upgrade index 7cb5395bf..1aefe7b09 100755 --- a/ccm-portalworkspace/src/ccm-portalworkspace.upgrade +++ b/ccm-portalworkspace/src/ccm-portalworkspace.upgrade @@ -27,4 +27,8 @@