LibreCCM
/
libreccm-legacy
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

- Kleine Optimierung RelatedLinkTable 

- Neue RelatedLinks erhalten jetzt wieder eine richtige Order-Angabe


git-svn-id: https://svn.libreccm.org/ccm/trunk@898 8810af33-2d31-482b-a856-94f89814c4df
master
jensp 2011-05-06 16:13:37 +00:00
parent 9c810f3e97
commit d4ad0bb5d8
7 changed files with 339 additions and 304 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
ccm-cms-assets-relatedlink/src/com/arsdigita/cms/contentassets/RelatedLink.java
View File

@ -42,23 +42,21 @@ import org.apache.log4j.Logger;
public class RelatedLink extends Link { public class RelatedLink extends Link {
private static final Logger s_log = Logger.getLogger(RelatedLink.class); private static final Logger s_log = Logger.getLogger(RelatedLink.class);
/** PDL properties */ /** PDL properties */
public static final String LINK_LIST_NAME = "linkListName"; public static final String LINK_LIST_NAME = "linkListName";
public static final String RESOURCE_SIZE = "resourceSize"; public static final String RESOURCE_SIZE = "resourceSize";
public static final String RESOURCE_TYPE = "resourceType"; public static final String RESOURCE_TYPE = "resourceType";
public static final String LINK_OWNER = "linkOwner"; public static final String LINK_OWNER = "linkOwner";
public static final String RELATED_LINKS = "links"; public static final String RELATED_LINKS = "links";
/** Data object type for this domain object */ /** Data object type for this domain object */
public static final String BASE_DATA_OBJECT_TYPE public static final String BASE_DATA_OBJECT_TYPE =
= "com.arsdigita.cms.contentassets.RelatedLink"; "com.arsdigita.cms.contentassets.RelatedLink";
/** /**
* Default constructor. This creates a new RelatedLink. * Default constructor. This creates a new RelatedLink.
*/ */
public RelatedLink() { public RelatedLink() {
this( BASE_DATA_OBJECT_TYPE ); this(BASE_DATA_OBJECT_TYPE);
} }
/** /**
@ -69,9 +67,9 @@ public class RelatedLink extends Link {
* @param id The <code>id</code> for the retrieved * @param id The <code>id</code> for the retrieved
* <code>DataObject</code> * <code>DataObject</code>
*/ */
public RelatedLink( BigDecimal id ) public RelatedLink(BigDecimal id)
throws DataObjectNotFoundException { throws DataObjectNotFoundException {
this( new OID( BASE_DATA_OBJECT_TYPE, id ) ); this(new OID(BASE_DATA_OBJECT_TYPE, id));
} }
/** /**
@ -82,9 +80,9 @@ public class RelatedLink extends Link {
* @param oid The <code>OID</code> for the retrieved * @param oid The <code>OID</code> for the retrieved
* <code>DataObject</code> * <code>DataObject</code>
*/ */
public RelatedLink( OID oid ) public RelatedLink(OID oid)
throws DataObjectNotFoundException { throws DataObjectNotFoundException {
super( oid ); super(oid);
} }
/** /**
@ -94,8 +92,8 @@ public class RelatedLink extends Link {
* @param obj The <code>DataObject</code> with which to create or * @param obj The <code>DataObject</code> with which to create or
* load a content item * load a content item
*/ */
public RelatedLink( DataObject obj ) { public RelatedLink(DataObject obj) {
super( obj ); super(obj);
} }
/** /**
@ -105,18 +103,18 @@ public class RelatedLink extends Link {
* @param type The <code>String</code> data object type of the * @param type The <code>String</code> data object type of the
* item to create * item to create
*/ */
public RelatedLink( String type ) { public RelatedLink(String type) {
super( type ); super(type);
} }
/** get the name of the named link list. */ /** get the name of the named link list. */
public String getLinkListName(){ public String getLinkListName() {
return (String) get(LINK_LIST_NAME); return (String) get(LINK_LIST_NAME);
} }
/** Set the name of the named link list. */ /** Set the name of the named link list. */
public void setLinkListName(String name){ public void setLinkListName(String name) {
set(LINK_LIST_NAME , name); set(LINK_LIST_NAME, name);
} }
/** /**
@ -124,9 +122,9 @@ public class RelatedLink extends Link {
* *
* @return <code>MimeType</code> of target resource. * @return <code>MimeType</code> of target resource.
*/ */
public MimeType getResourceType(){ public MimeType getResourceType() {
DataObject obj = (DataObject) get ( RESOURCE_TYPE ); DataObject obj = (DataObject) get(RESOURCE_TYPE);
if(obj != null){ if (obj != null) {
return new MimeType(obj); return new MimeType(obj);
} }
return null; return null;
@ -137,18 +135,18 @@ public class RelatedLink extends Link {
* *
* @param type , <code>MimeType</code> of target resource. * @param type , <code>MimeType</code> of target resource.
*/ */
public void setResourceType(MimeType type){ public void setResourceType(MimeType type) {
setAssociation(RESOURCE_TYPE , type); setAssociation(RESOURCE_TYPE, type);
} }
/** get the size of the target resource. */ /** get the size of the target resource. */
public String getResourceSize(){ public String getResourceSize() {
return (String) get(RESOURCE_SIZE); return (String) get(RESOURCE_SIZE);
} }
/** Set the size of the target resource. */ /** Set the size of the target resource. */
public void setResourceSize(String size){ public void setResourceSize(String size) {
set(RESOURCE_SIZE , size); set(RESOURCE_SIZE, size);
} }
/** /**
@ -172,7 +170,7 @@ public class RelatedLink extends Link {
if (dobj == null) { if (dobj == null) {
return null; return null;
} else { } else {
return (ContentItem)DomainObjectFactory.newInstance(dobj); return (ContentItem) DomainObjectFactory.newInstance(dobj);
} }
} }
@ -185,12 +183,20 @@ public class RelatedLink extends Link {
* @return * @return
*/ */
public static DataCollection getRelatedLinks(ContentItem item, String name) { public static DataCollection getRelatedLinks(ContentItem item, String name) {
s_log.debug("Getting related links for a content item"); s_log.debug(String.format("Getting related links for content item %s",
item.getID()));
long now = System.currentTimeMillis();
s_log.debug(String.format("Started at %d", now));
Session session = SessionManager.getSession(); Session session = SessionManager.getSession();
DataCollection links = session.retrieve(BASE_DATA_OBJECT_TYPE); DataCollection links = session.retrieve(BASE_DATA_OBJECT_TYPE);
links.addEqualsFilter(LINK_OWNER + ".id", item.getID()); links.addEqualsFilter(LINK_OWNER + ".id", item.getID());
links.addEqualsFilter(LINK_LIST_NAME, name); links.addEqualsFilter(LINK_LIST_NAME, name);
links.addOrder(ORDER); links.addOrder(ORDER);
s_log.debug(String.format(
"Got all related links for content item %s in %d ms. (time finished: %d)",
item.getID().toString(),
System.currentTimeMillis() - now,
System.currentTimeMillis()));
return links; return links;
} }
@ -205,20 +211,22 @@ public class RelatedLink extends Link {
public static DataCollection getReferringRelatedLinks(ContentItem item) { public static DataCollection getReferringRelatedLinks(ContentItem item) {
Session session = SessionManager.getSession(); Session session = SessionManager.getSession();
DataCollection links = session.retrieve(BASE_DATA_OBJECT_TYPE); DataCollection links = session.retrieve(BASE_DATA_OBJECT_TYPE);
Filter filter = links.addInSubqueryFilter("id", "com.arsdigita.cms.contentassets.getReferringRelatedLinks"); Filter filter =
links.addInSubqueryFilter("id",
"com.arsdigita.cms.contentassets.getReferringRelatedLinks");
filter.set("itemID", item.getID()); filter.set("itemID", item.getID());
return links; return links;
} }
/** /**
* Swaps this <code>RelatedLink</code> with the next one, * Swaps this <code>RelatedLink</code> with the next one,
* according to the linkOrder * according to the linkOrder
*/ */
@Override @Override
public void swapWithNext() { public void swapWithNext() {
swapWithNext("com.arsdigita.cms.contentassets.allRelatedLinkOrderForItem", swapWithNext(
"com.arsdigita.cms.contentassets.allRelatedLinkOrderForItem",
"com.arsdigita.cms.contentassets.swapRelatedLinkWithNextInGroup", "com.arsdigita.cms.contentassets.swapRelatedLinkWithNextInGroup",
this.getLinkListName()); this.getLinkListName());
} }
@ -229,7 +237,8 @@ public class RelatedLink extends Link {
*/ */
@Override @Override
public void swapWithPrevious() { public void swapWithPrevious() {
swapWithPrevious("com.arsdigita.cms.contentassets.allRelatedLinkOrderForItem", swapWithPrevious(
"com.arsdigita.cms.contentassets.allRelatedLinkOrderForItem",
"com.arsdigita.cms.contentassets.swapRelatedLinkWithNextInGroup", "com.arsdigita.cms.contentassets.swapRelatedLinkWithNextInGroup",
this.getLinkListName()); this.getLinkListName());
} }
@ -268,8 +277,6 @@ public class RelatedLink extends Link {
return operation; return operation;
} }
/** /**
* This method is only used for setting initial sort keys for * This method is only used for setting initial sort keys for
* links which exist without them. This is called by swapKeys * links which exist without them. This is called by swapKeys
@ -306,13 +313,13 @@ public class RelatedLink extends Link {
return 0; return 0;
} }
int returnOrder = 0; int returnOrder = 0;
DataQuery query = SessionManager.getSession().retrieveQuery DataQuery query = SessionManager.getSession().retrieveQuery(
("com.arsdigita.cms.contentassets.allRelatedLinkOrderForItem"); "com.arsdigita.cms.contentassets.allRelatedLinkOrderForItem");
query.setParameter("ownerID", getLinkOwner().getID()); query.setParameter("ownerID", getLinkOwner().getID());
query.setParameter("linkListName", getLinkListName()); query.setParameter("linkListName", getLinkListName());
query.addOrder("linkOrder DESC"); query.addOrder("linkOrder DESC");
if (query.next()) { if (query.next()) {
Integer linkOrder = ((Integer)query.get("linkOrder")); Integer linkOrder = ((Integer) query.get("linkOrder"));
query.close(); query.close();
if (linkOrder != null) { if (linkOrder != null) {
returnOrder = linkOrder.intValue(); returnOrder = linkOrder.intValue();
@ -326,7 +333,7 @@ public class RelatedLink extends Link {
public void beforeSave() { public void beforeSave() {
super.beforeSave(); super.beforeSave();
if (getOrder() == null) { if (getOrder() == null) {
setOrder(maxOrder()+1); setOrder(maxOrder() + 1);
} }
} }
} }

5
ccm-cms-assets-relatedlink/src/com/arsdigita/cms/contentassets/ui/RelatedLinkPropertyForm.java
View File

@ -35,6 +35,7 @@ import com.arsdigita.cms.contentassets.RelatedLink;
import com.arsdigita.globalization.GlobalizedMessage; import com.arsdigita.globalization.GlobalizedMessage;
import com.arsdigita.mimetypes.MimeType; import com.arsdigita.mimetypes.MimeType;
import com.arsdigita.mimetypes.MimeTypeCollection; import com.arsdigita.mimetypes.MimeTypeCollection;
import com.arsdigita.persistence.DataCollection;
import com.arsdigita.util.Assert; import com.arsdigita.util.Assert;
import org.apache.log4j.Logger; import org.apache.log4j.Logger;
@ -190,6 +191,10 @@ public class RelatedLinkPropertyForm extends LinkPropertyForm {
rl.setResourceType(mType); rl.setResourceType(mType);
} }
rl.setLinkListName((String) data.get(RelatedLink.LINK_LIST_NAME)); rl.setLinkListName((String) data.get(RelatedLink.LINK_LIST_NAME));
DataCollection links = RelatedLink.getRelatedLinks(getContentItem(fse.getPageState()), m_linkListName);
rl.setOrder((int) links.size() + 1);
super.setLinkProperties(link, fse); super.setLinkProperties(link, fse);
} }
} }

15
ccm-cms/src/com/arsdigita/cms/contenttypes/Link.java
View File

@ -165,7 +165,8 @@ public class Link extends ACSObject {
* Link.INTERNAL_LINK * Link.INTERNAL_LINK
*/ */
public void setTargetType(String type) { public void setTargetType(String type) {
Assert.isTrue(type != null && (type.equals(EXTERNAL_LINK) || type.equals( Assert.isTrue(type != null && (type.equals(EXTERNAL_LINK)
|| type.equals(
INTERNAL_LINK))); INTERNAL_LINK)));
set(TARGET_TYPE, type); set(TARGET_TYPE, type);
} }
@ -207,7 +208,8 @@ public class Link extends ACSObject {
// If acsObject is instance of ContentBundle // If acsObject is instance of ContentBundle
if (acsObject instanceof ContentBundle) { if (acsObject instanceof ContentBundle) {
// get the negotiated language version of this ContentBundle // get the negotiated language version of this ContentBundle
ci = ((ContentBundle) acsObject).negotiate(DispatcherHelper.getRequest().getLocales()); ci = ((ContentBundle) acsObject).negotiate(DispatcherHelper.
getRequest().getLocales());
} else { } else {
// else there are no language versions so just use the acsObject // else there are no language versions so just use the acsObject
ci = (ContentItem) acsObject; ci = (ContentItem) acsObject;
@ -299,6 +301,7 @@ public class Link extends ACSObject {
* @return the Link URI * @return the Link URI
*/ */
public String getInternalOrExternalURI(PageState state) { public String getInternalOrExternalURI(PageState state) {
if (EXTERNAL_LINK.equals(getTargetType())) { if (EXTERNAL_LINK.equals(getTargetType())) {
return getTargetURI(); return getTargetURI();
} else { } else {
@ -400,7 +403,8 @@ public class Link extends ACSObject {
swapKeys(true, queryName, operationName, ""); swapKeys(true, queryName, operationName, "");
} }
public void swapWithNext(String queryName, String operationName, String linkListName) { public void swapWithNext(String queryName, String operationName,
String linkListName) {
swapKeys(true, queryName, operationName, linkListName); swapKeys(true, queryName, operationName, linkListName);
} }
@ -417,7 +421,8 @@ public class Link extends ACSObject {
swapKeys(false, queryName, operationName, ""); swapKeys(false, queryName, operationName, "");
} }
public void swapWithPrevious(String queryName, String operationName, String linkListName) { public void swapWithPrevious(String queryName, String operationName,
String linkListName) {
swapKeys(false, queryName, operationName, linkListName); swapKeys(false, queryName, operationName, linkListName);
} }
@ -493,6 +498,8 @@ public class Link extends ACSObject {
int otherKey = key; int otherKey = key;
if (swapNext) { if (swapNext) {
otherKey = key + 1; otherKey = key + 1;
query.addOrder("linkOrder ASC"); query.addOrder("linkOrder ASC");

53
ccm-cms/src/com/arsdigita/cms/contenttypes/ui/LinkTable.java
View File

@ -50,7 +50,6 @@ import com.arsdigita.cms.dispatcher.Utilities;
* @version $Revision: #6 $ $Date: 2004/08/17 $ * @version $Revision: #6 $ $Date: 2004/08/17 $
* @author Nobuko Asakai (nasakai@redhat.com) * @author Nobuko Asakai (nasakai@redhat.com)
*/ */
public class LinkTable extends Table { public class LinkTable extends Table {
private static final Logger s_log = Logger.getLogger(LinkTable.class); private static final Logger s_log = Logger.getLogger(LinkTable.class);
@ -62,11 +61,8 @@ public class LinkTable extends Table {
private TableColumn m_moveDownCol; private TableColumn m_moveDownCol;
private TableColumn m_editCol; private TableColumn m_editCol;
private TableColumn m_delCol; private TableColumn m_delCol;
private RequestLocal m_size; private RequestLocal m_size;
private RequestLocal m_editor; private RequestLocal m_editor;
protected static final String EDIT_EVENT = "Edit"; protected static final String EDIT_EVENT = "Edit";
protected static final String DELETE_EVENT = "Delete"; protected static final String DELETE_EVENT = "Delete";
protected static final String UP_EVENT = "up"; protected static final String UP_EVENT = "up";
@ -90,15 +86,15 @@ public class LinkTable extends Table {
m_size = new RequestLocal(); m_size = new RequestLocal();
m_editor = new RequestLocal() { m_editor = new RequestLocal() {
public Object initialValue(PageState state) { public Object initialValue(PageState state) {
SecurityManager sm = Utilities.getSecurityManager(state); SecurityManager sm = Utilities.getSecurityManager(state);
ContentItem item = (ContentItem)m_itemModel ContentItem item = (ContentItem) m_itemModel.getSelectedObject(
.getSelectedObject(state); state);
Boolean val = new Boolean(sm.canAccess( Boolean val = new Boolean(sm.canAccess(
state.getRequest(), state.getRequest(),
SecurityManager.EDIT_ITEM, SecurityManager.EDIT_ITEM,
item item));
));
return val; return val;
} }
}; };
@ -135,6 +131,7 @@ public class LinkTable extends Table {
* TableCellRenderer class for LinkTable * TableCellRenderer class for LinkTable
*/ */
private class LinkTableRenderer implements TableCellRenderer { private class LinkTableRenderer implements TableCellRenderer {
public Component getComponent(Table table, public Component getComponent(Table table,
PageState state, PageState state,
Object value, Object value,
@ -142,29 +139,30 @@ public class LinkTable extends Table {
Object key, Object key,
int row, int row,
int column) { int column) {
Link link = (Link)value; Link link = (Link) value;
boolean isFirst = (row == 0); boolean isFirst = (row == 0);
if (m_size.get(state) == null) { if (m_size.get(state) == null) {
m_size.set(state, m_size.set(state,
new Long(((LinkTableModelBuilder.LinkTableModel) new Long(((LinkTableModelBuilder.LinkTableModel) table.
table.getTableModel(state)).size())); getTableModel(state)).size()));
} }
boolean isLast = (row == ((Long)m_size.get(state)).intValue() - 1); boolean isLast = (row == ((Long) m_size.get(state)).intValue() - 1);
String url = link.getInternalOrExternalURI(state);
if (column == m_titleCol.getModelIndex()) { if (column == m_titleCol.getModelIndex()) {
String url = link.getInternalOrExternalURI(state);
ExternalLink extLink = new ExternalLink(link.getTitle(), url); ExternalLink extLink = new ExternalLink(link.getTitle(), url);
extLink.setTargetFrame("_blank"); extLink.setTargetFrame("_blank");
return extLink; return extLink;
} else if ( column == m_descCol.getModelIndex()) { } else if (column == m_descCol.getModelIndex()) {
if ( isSelected ) { if (isSelected) {
return new Label(link.getDescription(), Label.BOLD); return new Label(link.getDescription(), Label.BOLD);
} else { } else {
return new Label(link.getDescription()); return new Label(link.getDescription());
} }
} else if ( column == m_editCol.getModelIndex()) { } else if (column == m_editCol.getModelIndex()) {
if (Boolean.TRUE.equals(m_editor.get(state))) { if (Boolean.TRUE.equals(m_editor.get(state))) {
if (isSelected ) { if (isSelected) {
return new Label(EDIT_EVENT, Label.BOLD); return new Label(EDIT_EVENT, Label.BOLD);
} else { } else {
return new ControlLink(EDIT_EVENT); return new ControlLink(EDIT_EVENT);
@ -172,7 +170,7 @@ public class LinkTable extends Table {
} else { } else {
return new Label(EDIT_EVENT); return new Label(EDIT_EVENT);
} }
} else if ( column == m_delCol.getModelIndex()) { } else if (column == m_delCol.getModelIndex()) {
if (Boolean.TRUE.equals(m_editor.get(state))) { if (Boolean.TRUE.equals(m_editor.get(state))) {
return new ControlLink(DELETE_EVENT); return new ControlLink(DELETE_EVENT);
} else { } else {
@ -204,20 +202,22 @@ public class LinkTable extends Table {
* TableActionListener class for LinkTable * TableActionListener class for LinkTable
*/ */
private class LinkTableActionListener implements TableActionListener { private class LinkTableActionListener implements TableActionListener {
private Link getLink(TableActionEvent e) { private Link getLink(TableActionEvent e) {
Object o = e.getRowKey(); Object o = e.getRowKey();
BigDecimal id; BigDecimal id;
if (o instanceof String) { if (o instanceof String) {
s_log.debug("row key is a string : " + o); s_log.debug("row key is a string : " + o);
id = new BigDecimal((String)o); id = new BigDecimal((String) o);
} else { } else {
id = (BigDecimal)e.getRowKey(); id = (BigDecimal) e.getRowKey();
} }
Assert.exists(id); Assert.exists(id);
Link link; Link link;
try { try {
link = (Link)DomainObjectFactory.newInstance(new OID(Link.BASE_DATA_OBJECT_TYPE,id)); link = (Link) DomainObjectFactory.newInstance(new OID(
Link.BASE_DATA_OBJECT_TYPE, id));
} catch (DataObjectNotFoundException de) { } catch (DataObjectNotFoundException de) {
throw new UncheckedWrapperException(de); throw new UncheckedWrapperException(de);
} }
@ -230,7 +230,7 @@ public class LinkTable extends Table {
Link link = getLink(e); Link link = getLink(e);
Assert.exists(link); Assert.exists(link);
if (col== m_titleCol.getModelIndex()) { if (col == m_titleCol.getModelIndex()) {
// do nothing // do nothing
} else if (col == m_editCol.getModelIndex()) { } else if (col == m_editCol.getModelIndex()) {
if (Boolean.TRUE.equals(m_editor.get(state))) { if (Boolean.TRUE.equals(m_editor.get(state))) {
@ -244,21 +244,22 @@ public class LinkTable extends Table {
s_log.debug("About to delete"); s_log.debug("About to delete");
m_linkModel.clearSelection(state); m_linkModel.clearSelection(state);
link.delete(); link.delete();
} catch ( PersistenceException pe) { } catch (PersistenceException pe) {
throw new UncheckedWrapperException(pe); throw new UncheckedWrapperException(pe);
} }
} }
} else if (col == m_moveUpCol.getModelIndex() ) { } else if (col == m_moveUpCol.getModelIndex()) {
// move the link up // move the link up
m_linkModel.clearSelection(state); m_linkModel.clearSelection(state);
link.swapWithPrevious(); link.swapWithPrevious();
} else if ( col == m_moveDownCol.getModelIndex() ) { } else if (col == m_moveDownCol.getModelIndex()) {
// move the link down // move the link down
m_linkModel.clearSelection(state); m_linkModel.clearSelection(state);
link.swapWithNext(); link.swapWithNext();
} }
} }
public void headSelected(TableActionEvent e) {} public void headSelected(TableActionEvent e) {
}
} }
} }

17
ccm-cms/src/com/arsdigita/cms/contenttypes/ui/LinkTableModelBuilder.java
View File

@ -36,13 +36,12 @@ import org.apache.log4j.Logger;
* @version $Revision: #4 $ $Date: 2004/08/17 $ * @version $Revision: #4 $ $Date: 2004/08/17 $
* @author Nobuko Asakai (nasakai@redhat.com) * @author Nobuko Asakai (nasakai@redhat.com)
*/ */
public abstract class LinkTableModelBuilder public abstract class LinkTableModelBuilder
extends LockableImpl implements TableModelBuilder { extends LockableImpl implements TableModelBuilder {
private static final Logger s_log = private static final Logger s_log =
Logger.getLogger(LinkTableModelBuilder.class); Logger.getLogger(LinkTableModelBuilder.class);
/** /**
* Creates the LinKTableModel based on the current table and pagestate * Creates the LinKTableModel based on the current table and pagestate
* *
@ -55,7 +54,7 @@ public abstract class LinkTableModelBuilder
DataCollection links = getLinks(s); DataCollection links = getLinks(s);
if ( links.isEmpty() ) { if (links.isEmpty()) {
return Table.EMPTY_MODEL; return Table.EMPTY_MODEL;
} else { } else {
return new LinkTableModel(links); return new LinkTableModel(links);
@ -78,15 +77,22 @@ public abstract class LinkTableModelBuilder
Link m_link; Link m_link;
DataCollection m_links; DataCollection m_links;
public LinkTableModel(DataCollection links) { public LinkTableModel(DataCollection links) {
m_links = links; m_links = links;
m_link = null; m_link = null;
} }
public boolean nextRow() { public boolean nextRow() {
s_log.debug(String.format("m_links.size() = %d", m_links.size()));
if (m_links.next()) { if (m_links.next()) {
s_log.debug("Getting domain object for link...");
long now = System.currentTimeMillis();
DataObject object = m_links.getDataObject(); DataObject object = m_links.getDataObject();
m_link = (Link)DomainObjectFactory.newInstance(object); m_link = (Link) DomainObjectFactory.newInstance(object);
s_log.debug(String.format("Got domain object in %d ms", System.
currentTimeMillis() - now));
return true; return true;
} else { } else {
return false; return false;
@ -94,7 +100,7 @@ public abstract class LinkTableModelBuilder
} }
public int getColumnCount() { public int getColumnCount() {
return (int)m_links.size(); return (int) m_links.size();
} }
@ -105,6 +111,7 @@ public abstract class LinkTableModelBuilder
public Object getKeyAt(int columnIndex) { public Object getKeyAt(int columnIndex) {
return m_link.getID(); return m_link.getID();
} }
public long size() { public long size() {
return m_links.size(); return m_links.size();
} }

140
ccm-core/src/com/arsdigita/bebop/Table.java
View File

@ -38,6 +38,7 @@ import com.arsdigita.util.Assert;
import com.arsdigita.xml.Element; import com.arsdigita.xml.Element;
import java.util.Iterator; import java.util.Iterator;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import org.apache.log4j.Logger;
/** /**
* Displays statically or * Displays statically or
@ -92,45 +93,33 @@ import javax.servlet.ServletException;
*/ */
public class Table extends BlockStylable implements BebopConstants { public class Table extends BlockStylable implements BebopConstants {
private static final Logger logger = Logger.getLogger(Table.class);
// Names for HTML Attributes // Names for HTML Attributes
private static final String WIDTH = "width"; private static final String WIDTH = "width";
private static final String CELL_SPACING = "cellspacing"; private static final String CELL_SPACING = "cellspacing";
private static final String CELL_PADDING = "cellpadding"; private static final String CELL_PADDING = "cellpadding";
private static final String BORDER = "border"; private static final String BORDER = "border";
private static final String SELECTED_ROW = "row";
private static final String SELECTED_ROW="row";
/** /**
* The control event when the user selects one table cell. * The control event when the user selects one table cell.
* This control event will only be used when * This control event will only be used when
*/ */
protected static final String CELL_EVENT = "cell"; protected static final String CELL_EVENT = "cell";
protected static final char SEP = ' '; protected static final char SEP = ' ';
private TableModelBuilder m_modelBuilder; private TableModelBuilder m_modelBuilder;
private TableColumnModel m_columnModel; private TableColumnModel m_columnModel;
private TableHeader m_header; private TableHeader m_header;
private RequestLocal m_tableModel; private RequestLocal m_tableModel;
private SingleSelectionModel m_rowSelectionModel; private SingleSelectionModel m_rowSelectionModel;
/** /**
* A listener to forward headSelected events originating from the * A listener to forward headSelected events originating from the
* TableHeader. This will be null until somebody actually registers a * TableHeader. This will be null until somebody actually registers a
* TableActionListener from the outside. * TableActionListener from the outside.
*/ */
private TableActionListener m_headerForward; private TableActionListener m_headerForward;
private EventListenerList m_listeners; private EventListenerList m_listeners;
private TableCellRenderer m_defaultCellRenderer; private TableCellRenderer m_defaultCellRenderer;
private Component m_emptyView; private Component m_emptyView;
private boolean m_striped = false; private boolean m_striped = false;
/** /**
@ -191,7 +180,6 @@ public class Table extends BlockStylable implements BebopConstants {
} }
// Events and listeners // Events and listeners
/** /**
* Adds a {@link TableActionListener} to the table. The listener is * Adds a {@link TableActionListener} to the table. The listener is
* fired whenever a table cell is clicked. * fired whenever a table cell is clicked.
@ -200,16 +188,15 @@ public class Table extends BlockStylable implements BebopConstants {
*/ */
public void addTableActionListener(TableActionListener l) { public void addTableActionListener(TableActionListener l) {
Assert.isUnlocked(this); Assert.isUnlocked(this);
if ( m_headerForward == null ) { if (m_headerForward == null) {
m_headerForward = createTableActionListener(); m_headerForward = createTableActionListener();
if ( m_header != null ) { if (m_header != null) {
m_header.addTableActionListener(m_headerForward); m_header.addTableActionListener(m_headerForward);
} }
} }
m_listeners.add(TableActionListener.class, l); m_listeners.add(TableActionListener.class, l);
} }
/** /**
* Removes a {@link TableActionListener} from the table. * Removes a {@link TableActionListener} from the table.
* *
@ -230,12 +217,11 @@ public class Table extends BlockStylable implements BebopConstants {
*/ */
protected void fireCellSelected(PageState state, protected void fireCellSelected(PageState state,
Object rowKey, Integer column) { Object rowKey, Integer column) {
Iterator Iterator i = m_listeners.getListenerIterator(TableActionListener.class);
i=m_listeners.getListenerIterator(TableActionListener.class);
TableActionEvent e = null; TableActionEvent e = null;
while (i.hasNext()) { while (i.hasNext()) {
if ( e == null ) { if (e == null) {
e = new TableActionEvent(this, state, rowKey, column); e = new TableActionEvent(this, state, rowKey, column);
} }
((TableActionListener) i.next()).cellSelected(e); ((TableActionListener) i.next()).cellSelected(e);
@ -252,19 +238,17 @@ public class Table extends BlockStylable implements BebopConstants {
*/ */
protected void fireHeadSelected(PageState state, protected void fireHeadSelected(PageState state,
Object rowKey, Integer column) { Object rowKey, Integer column) {
Iterator Iterator i = m_listeners.getListenerIterator(TableActionListener.class);
i=m_listeners.getListenerIterator(TableActionListener.class);
TableActionEvent e = null; TableActionEvent e = null;
while (i.hasNext()) { while (i.hasNext()) {
if ( e == null ) { if (e == null) {
e = new TableActionEvent(this, state, rowKey, column); e = new TableActionEvent(this, state, rowKey, column);
} }
((TableActionListener) i.next()).headSelected(e); ((TableActionListener) i.next()).headSelected(e);
} }
} }
/** /**
* Instantiates a new {@link TableActionListener} for this table. * Instantiates a new {@link TableActionListener} for this table.
* *
@ -274,13 +258,13 @@ public class Table extends BlockStylable implements BebopConstants {
*/ */
protected TableActionListener createTableActionListener() { protected TableActionListener createTableActionListener() {
return new TableActionAdapter() { return new TableActionAdapter() {
public void headSelected(TableActionEvent e) { public void headSelected(TableActionEvent e) {
fireHeadSelected(e.getPageState(), e.getRowKey(), e.getColumn()); fireHeadSelected(e.getPageState(), e.getRowKey(), e.getColumn());
} }
}; };
} }
/** /**
* @return the {@link TableColumnModel} for this table. * @return the {@link TableColumnModel} for this table.
*/ */
@ -331,16 +315,16 @@ public class Table extends BlockStylable implements BebopConstants {
*/ */
public void setHeader(TableHeader v) { public void setHeader(TableHeader v) {
Assert.isUnlocked(this); Assert.isUnlocked(this);
if ( m_headerForward != null ) { if (m_headerForward != null) {
if ( m_header != null ) { if (m_header != null) {
m_header.removeTableActionListener(m_headerForward); m_header.removeTableActionListener(m_headerForward);
} }
if ( v != null ) { if (v != null) {
v.addTableActionListener(m_headerForward); v.addTableActionListener(m_headerForward);
} }
} }
m_header = v; m_header = v;
if ( m_header != null ) { if (m_header != null) {
m_header.setTable(this); m_header.setTable(this);
} }
} }
@ -389,8 +373,8 @@ public class Table extends BlockStylable implements BebopConstants {
* for selecting the current column. * for selecting the current column.
*/ */
public SingleSelectionModel getColumnSelectionModel() { public SingleSelectionModel getColumnSelectionModel() {
return ( getColumnModel() == null ) ? null : return (getColumnModel() == null) ? null : getColumnModel().
getColumnModel().getSelectionModel(); getSelectionModel();
} }
/** /**
@ -443,7 +427,6 @@ public class Table extends BlockStylable implements BebopConstants {
return m_emptyView; return m_emptyView;
} }
/** /**
* Sets the empty view. The empty view is the component that * Sets the empty view. The empty view is the component that
* is shown if the table is empty. Usually, the component * is shown if the table is empty. Usually, the component
@ -456,7 +439,6 @@ public class Table extends BlockStylable implements BebopConstants {
} }
// Set HTML table attributes // Set HTML table attributes
/** /**
* *
* @return the HTML width of the table. * @return the HTML width of the table.
@ -489,7 +471,6 @@ public class Table extends BlockStylable implements BebopConstants {
setAttribute(BORDER, v); setAttribute(BORDER, v);
} }
public String getCellSpacing() { public String getCellSpacing() {
return getAttribute(CELL_SPACING); return getAttribute(CELL_SPACING);
} }
@ -529,13 +510,13 @@ public class Table extends BlockStylable implements BebopConstants {
String rowKey = null; String rowKey = null;
Integer column = null; Integer column = null;
if ( CELL_EVENT.equals(event) ) { if (CELL_EVENT.equals(event)) {
String value = s.getControlEventValue(); String value = s.getControlEventValue();
SingleSelectionModel rowSel = getRowSelectionModel(); SingleSelectionModel rowSel = getRowSelectionModel();
SingleSelectionModel colSel = getColumnSelectionModel(); SingleSelectionModel colSel = getColumnSelectionModel();
int split = value.indexOf(SEP); int split = value.indexOf(SEP);
rowKey = value.substring(0, split); rowKey = value.substring(0, split);
column = new Integer(value.substring(split+1)); column = new Integer(value.substring(split + 1));
colSel.setSelectedKey(s, column); colSel.setSelectedKey(s, column);
rowSel.setSelectedKey(s, rowKey); rowSel.setSelectedKey(s, rowKey);
fireCellSelected(s, rowKey, column); fireCellSelected(s, rowKey, column);
@ -552,12 +533,14 @@ public class Table extends BlockStylable implements BebopConstants {
* @param p the page that contains this table * @param p the page that contains this table
*/ */
public void register(Page p) { public void register(Page p) {
ParameterModel m = getRowSelectionModel() == null ? null : getRowSelectionModel().getStateParameter(); ParameterModel m = getRowSelectionModel() == null ? null
if ( m != null ) { : getRowSelectionModel().getStateParameter();
if (m != null) {
p.addComponentStateParam(this, m); p.addComponentStateParam(this, m);
} }
m = getColumnSelectionModel() == null ? null : getColumnSelectionModel().getStateParameter(); m = getColumnSelectionModel() == null ? null : getColumnSelectionModel().
if ( m != null ) { getStateParameter();
if (m != null) {
p.addComponentStateParam(this, m); p.addComponentStateParam(this, m);
} }
return; return;
@ -571,15 +554,16 @@ public class Table extends BlockStylable implements BebopConstants {
*/ */
public Iterator children() { public Iterator children() {
return new Iterator() { return new Iterator() {
int pos = (getHeader()==null) ? -1 : -2;
int pos = (getHeader() == null) ? -1 : -2;
public boolean hasNext() { public boolean hasNext() {
return pos < getColumnModel().size() -1; return pos < getColumnModel().size() - 1;
} }
public Object next() { public Object next() {
pos += 1; pos += 1;
if ( pos == -1 ) { if (pos == -1) {
return getHeader(); return getHeader();
} else { } else {
return getColumn(pos); return getColumn(pos);
@ -601,7 +585,7 @@ public class Table extends BlockStylable implements BebopConstants {
* <code>false</code> otherwise. * <code>false</code> otherwise.
*/ */
public boolean isSelectedRow(PageState s, Object rowKey) { public boolean isSelectedRow(PageState s, Object rowKey) {
if ( rowKey == null || getRowSelectionModel() == null) { if (rowKey == null || getRowSelectionModel() == null) {
return false; return false;
} }
return getRowSelectionModel().isSelected(s) return getRowSelectionModel().isSelected(s)
@ -619,7 +603,7 @@ public class Table extends BlockStylable implements BebopConstants {
* <code>false</code> otherwise. * <code>false</code> otherwise.
*/ */
public boolean isSelectedColumn(PageState s, Object column) { public boolean isSelectedColumn(PageState s, Object column) {
if ( column == null || getColumnSelectionModel() == null) { if (column == null || getColumnSelectionModel() == null) {
return false; return false;
} }
return getColumnSelectionModel().isSelected(s) return getColumnSelectionModel().isSelected(s)
@ -644,7 +628,6 @@ public class Table extends BlockStylable implements BebopConstants {
return isSelectedRow(s, rowKey) && isSelectedColumn(s, column); return isSelectedRow(s, rowKey) && isSelectedColumn(s, column);
} }
public void setStriped(boolean striped) { public void setStriped(boolean striped) {
m_striped = striped; m_striped = striped;
} }
@ -701,7 +684,7 @@ public class Table extends BlockStylable implements BebopConstants {
Element table = p.newChildElement(BEBOP_TABLE, BEBOP_XML_NS); Element table = p.newChildElement(BEBOP_TABLE, BEBOP_XML_NS);
exportAttributes(table); exportAttributes(table);
generateExtraXMLAttributes(s, table); generateExtraXMLAttributes(s, table);
if ( getHeader() != null ) { if (getHeader() != null) {
getHeader().generateXML(s, table); getHeader().generateXML(s, table);
} }
Element tbody = table.newChildElement(BEBOP_TABLEBODY, BEBOP_XML_NS); Element tbody = table.newChildElement(BEBOP_TABLEBODY, BEBOP_XML_NS);
@ -711,37 +694,63 @@ public class Table extends BlockStylable implements BebopConstants {
final int modelSize = getColumnModel().size(); final int modelSize = getColumnModel().size();
int row = 0; int row = 0;
do {
Element trow = tbody.newChildElement(BEBOP_TABLEROW, BEBOP_XML_NS);
for (int i=0; i< modelSize; i++) { logger.debug("Creating table rows...");
long start = System.currentTimeMillis();
do {
long rowStart = System.currentTimeMillis();
Element trow = tbody.newChildElement(BEBOP_TABLEROW,
BEBOP_XML_NS);
for (int i = 0; i < modelSize; i++) {
TableColumn tc = getColumn(i); TableColumn tc = getColumn(i);
if ( tc.isVisible(s) ) { if (tc.isVisible(s)) {
TableCellRenderer r = tc.getCellRenderer(); TableCellRenderer r = tc.getCellRenderer();
if ( r == null ) { if (r == null) {
r = m_defaultCellRenderer; r = m_defaultCellRenderer;
} }
final int modelIndex = tc.getModelIndex(); final int modelIndex = tc.getModelIndex();
Object key = model.getKeyAt(modelIndex); Object key = model.getKeyAt(modelIndex);
Object value = model.getElementAt(modelIndex); Object value = model.getElementAt(modelIndex);
boolean selected = isSelectedCell(s, key, new Integer(i)); boolean selected =
isSelectedCell(s, key, new Integer(i));
if (tableIsRegisteredWithPage) { if (tableIsRegisteredWithPage) {
StringBuffer coords = new StringBuffer(40); /*StringBuffer coords = new StringBuffer(40);
coords.append(model.getKeyAt(modelIndex)) coords.append(model.getKeyAt(modelIndex)).append(SEP).
.append(SEP).append(i); append(i);
s.setControlEvent(getControler(), CELL_EVENT, s.setControlEvent(getControler(), CELL_EVENT,
coords.toString()); coords.toString());*/
s.setControlEvent(getControler(),
CELL_EVENT,
String.format("%s%s%d",
model.getKeyAt(
modelIndex),
SEP,
i));
} }
Element cell = trow.newChildElement(BEBOP_CELL, BEBOP_XML_NS);
Element cell = trow.newChildElement(BEBOP_CELL,
BEBOP_XML_NS);
tc.exportCellAttributes(cell); tc.exportCellAttributes(cell);
r.getComponent(this, s, value, selected, key, row, i) long begin = System.currentTimeMillis();
.generateXML(s, cell); r.getComponent(this, s, value, selected, key, row, i).
generateXML(s, cell);
logger.debug(String.format("until here i needed %d ms",
System.currentTimeMillis()
- begin));
} }
} }
row += 1; row += 1;
logger.debug(
String.format("Created row in %d ms",
System.currentTimeMillis() - rowStart));
} while (model.nextRow()); } while (model.nextRow());
} else if ( m_emptyView != null ) { logger.debug(String.format("Build table rows in %d ms",
System.currentTimeMillis() - start));
} else if (m_emptyView != null) {
m_emptyView.generateXML(s, p); m_emptyView.generateXML(s, p);
} }
if (tableIsRegisteredWithPage) { if (tableIsRegisteredWithPage) {
@ -771,6 +780,7 @@ public class Table extends BlockStylable implements BebopConstants {
*/ */
private void initTableModel() { private void initTableModel() {
m_tableModel = new RequestLocal() { m_tableModel = new RequestLocal() {
protected Object initialValue(PageState s) { protected Object initialValue(PageState s) {
return m_modelBuilder.makeModel(Table.this, s); return m_modelBuilder.makeModel(Table.this, s);
} }
@ -809,6 +819,7 @@ public class Table extends BlockStylable implements BebopConstants {
public TableModel makeModel(Table t, PageState s) { public TableModel makeModel(Table t, PageState s) {
return new TableModel() { return new TableModel() {
private int row = -1; private int row = -1;
public int getColumnCount() { public int getColumnCount() {
@ -816,7 +827,7 @@ public class Table extends BlockStylable implements BebopConstants {
} }
public boolean nextRow() { public boolean nextRow() {
return ( ++row < m_data.length ); return (++row < m_data.length);
} }
public Object getElementAt(int j) { public Object getElementAt(int j) {
@ -829,8 +840,6 @@ public class Table extends BlockStylable implements BebopConstants {
}; };
} }
} }
/** /**
* A {@link TableModel} that has no rows. * A {@link TableModel} that has no rows.
*/ */
@ -852,5 +861,4 @@ public class Table extends BlockStylable implements BebopConstants {
throw new IllegalStateException("TableModel is empty"); throw new IllegalStateException("TableModel is empty");
} }
}; };
} }