116 lines
5.4 KiB
JavaScript
116 lines
5.4 KiB
JavaScript
/**
|
|
* @license
|
|
* Copyright 2013 Palantir Technologies, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
"use strict";
|
|
var __extends = (this && this.__extends) || (function () {
|
|
var extendStatics = Object.setPrototypeOf ||
|
|
({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) ||
|
|
function (d, b) { for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p]; };
|
|
return function (d, b) {
|
|
extendStatics(d, b);
|
|
function __() { this.constructor = d; }
|
|
d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
|
|
};
|
|
})();
|
|
Object.defineProperty(exports, "__esModule", { value: true });
|
|
var ts = require("typescript");
|
|
var Lint = require("../index");
|
|
var Rule = (function (_super) {
|
|
__extends(Rule, _super);
|
|
function Rule() {
|
|
return _super !== null && _super.apply(this, arguments) || this;
|
|
}
|
|
Rule.prototype.apply = function (sourceFile) {
|
|
return this.applyWithWalker(new NoDuplicateVariableWalker(sourceFile, this.getOptions()));
|
|
};
|
|
return Rule;
|
|
}(Lint.Rules.AbstractRule));
|
|
/* tslint:disable:object-literal-sort-keys */
|
|
Rule.metadata = {
|
|
ruleName: "no-duplicate-variable",
|
|
description: "Disallows duplicate variable declarations in the same block scope.",
|
|
descriptionDetails: (_a = ["\n This rule is only useful when using the `var` keyword -\n the compiler will detect redeclarations of `let` and `const` variables."], _a.raw = ["\n This rule is only useful when using the \\`var\\` keyword -\n the compiler will detect redeclarations of \\`let\\` and \\`const\\` variables."], Lint.Utils.dedent(_a)),
|
|
rationale: (_b = ["\n A variable can be reassigned if necessary -\n there's no good reason to have a duplicate variable declaration."], _b.raw = ["\n A variable can be reassigned if necessary -\n there's no good reason to have a duplicate variable declaration."], Lint.Utils.dedent(_b)),
|
|
optionsDescription: "Not configurable.",
|
|
options: null,
|
|
optionExamples: ["true"],
|
|
type: "functionality",
|
|
typescriptOnly: false,
|
|
};
|
|
/* tslint:enable:object-literal-sort-keys */
|
|
Rule.FAILURE_STRING_FACTORY = function (name) {
|
|
return "Duplicate variable: '" + name + "'";
|
|
};
|
|
exports.Rule = Rule;
|
|
var NoDuplicateVariableWalker = (function (_super) {
|
|
__extends(NoDuplicateVariableWalker, _super);
|
|
function NoDuplicateVariableWalker() {
|
|
return _super !== null && _super.apply(this, arguments) || this;
|
|
}
|
|
NoDuplicateVariableWalker.prototype.createScope = function () {
|
|
return null;
|
|
};
|
|
NoDuplicateVariableWalker.prototype.createBlockScope = function () {
|
|
return new ScopeInfo();
|
|
};
|
|
NoDuplicateVariableWalker.prototype.visitBindingElement = function (node) {
|
|
var isSingleVariable = node.name.kind === ts.SyntaxKind.Identifier;
|
|
var isBlockScoped = Lint.isBlockScopedBindingElement(node);
|
|
// duplicate-variable errors for block-scoped vars are caught by tsc
|
|
if (isSingleVariable && !isBlockScoped) {
|
|
this.handleSingleVariableIdentifier(node.name);
|
|
}
|
|
_super.prototype.visitBindingElement.call(this, node);
|
|
};
|
|
NoDuplicateVariableWalker.prototype.visitCatchClause = function (node) {
|
|
// don't visit the catch clause variable declaration, just visit the block
|
|
// the catch clause variable declaration has its own special scoping rules
|
|
this.visitBlock(node.block);
|
|
};
|
|
NoDuplicateVariableWalker.prototype.visitMethodSignature = function (_node) {
|
|
// don't call super, we don't want to walk method signatures either
|
|
};
|
|
NoDuplicateVariableWalker.prototype.visitTypeLiteral = function (_node) {
|
|
// don't call super, we don't want to walk the inside of type nodes
|
|
};
|
|
NoDuplicateVariableWalker.prototype.visitVariableDeclaration = function (node) {
|
|
var isSingleVariable = node.name.kind === ts.SyntaxKind.Identifier;
|
|
// destructuring is handled by this.visitBindingElement()
|
|
if (isSingleVariable && !Lint.isBlockScopedVariable(node)) {
|
|
this.handleSingleVariableIdentifier(node.name);
|
|
}
|
|
_super.prototype.visitVariableDeclaration.call(this, node);
|
|
};
|
|
NoDuplicateVariableWalker.prototype.handleSingleVariableIdentifier = function (variableIdentifier) {
|
|
var variableName = variableIdentifier.text;
|
|
var currentBlockScope = this.getCurrentBlockScope();
|
|
if (currentBlockScope.varNames.indexOf(variableName) >= 0) {
|
|
this.addFailureAtNode(variableIdentifier, Rule.FAILURE_STRING_FACTORY(variableIdentifier.text));
|
|
}
|
|
else {
|
|
currentBlockScope.varNames.push(variableName);
|
|
}
|
|
};
|
|
return NoDuplicateVariableWalker;
|
|
}(Lint.BlockScopeAwareRuleWalker));
|
|
var ScopeInfo = (function () {
|
|
function ScopeInfo() {
|
|
this.varNames = [];
|
|
}
|
|
return ScopeInfo;
|
|
}());
|
|
var _a, _b;
|