From 86b924b5bc2400e4a8864ded6502fcd944e8fe50 Mon Sep 17 00:00:00 2001 From: Jens Pelzetter Date: Tue, 12 Jan 2021 21:12:51 +0100 Subject: [PATCH] Fixed several links in ccm-admin Former-commit-id: c2dbc409238d3e9aa1c5c697de1b6157767843ff --- .../java/org/libreccm/ui/admin/AdminPage.java | 11 +++-------- .../org/libreccm/ui/admin/AdminPageModel.java | 10 +++++----- .../org/libreccm/ui/admin/AdminPagesModel.java | 2 +- .../ui/admin/applications/ApplicationsPage.java | 7 ++----- .../ui/admin/categories/CategoriesPage.java | 7 ++----- .../admin/configuration/ConfigurationPage.java | 6 ++---- .../ui/admin/dashboard/DashboardPage.java | 6 ++---- .../libreccm/ui/admin/imexport/ImExportPage.java | 6 ++---- .../org/libreccm/ui/admin/sites/SitesPage.java | 6 ++---- .../SystemInformationController.java | 2 -- .../systeminformation/SystemInformationPage.java | 7 ++----- .../org/libreccm/ui/admin/themes/ThemesPage.java | 6 ++---- .../usersgroupsroles/UsersGroupsRolesPage.java | 7 ++----- .../categories/categorysystem-details.xhtml | 16 ++++++++-------- .../views/org/libreccm/ui/admin/ccm-admin.xhtml | 4 ++-- .../views/org/libreccm/ui/admin/dashboard.xhtml | 4 ++-- .../libreccm/ui/admin/sites/site-details.xhtml | 4 ++-- .../org/libreccm/ui/admin/sites/site-form.xhtml | 8 ++++---- .../org/libreccm/ui/admin/sites/sites.xhtml | 6 +++--- .../org/libreccm/ui/admin/themes/themes.xhtml | 10 +++++----- 20 files changed, 53 insertions(+), 82 deletions(-) diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPage.java index 88ed5dbe2..0c5d4e1d9 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPage.java @@ -38,16 +38,11 @@ public interface AdminPage { Set> getControllerClasses(); /** - * A identifier to use by {@link MvcContext#uri(java.lang.String)} to - * generate the URI of the page. The identifier has the same format as used - * in JavaDoc: - *
-     *     ControllerSimpleClassName#methodName
-     * 
+ * The URI fragment of the page behind {@code /@admin}. * - * @return The identifier to use for generating the URL of the page + * @return The URI fragment of the page behind {@code /@admin}. */ - String getUriIdentifier(); + String getPageUri(); /** * Gets the resourcebundle which provides the label of the admin page. diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPageModel.java b/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPageModel.java index 40eaf8b96..d011c65ba 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPageModel.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPageModel.java @@ -29,7 +29,7 @@ import java.util.Comparator; */ public class AdminPageModel implements Comparable { - private String uriIdentifier; + private String pageUri; private String label; @@ -39,12 +39,12 @@ public class AdminPageModel implements Comparable { private long position; - public String getUriIdentifier() { - return uriIdentifier; + public String getPageUri() { + return pageUri; } - protected void setUriIdentifier(final String uriIdentifier) { - this.uriIdentifier = uriIdentifier; + protected void setPageUri(final String pageUri) { + this.pageUri = pageUri; } public String getLabel() { diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPagesModel.java b/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPagesModel.java index d459d5a44..7e0bec4ad 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPagesModel.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/AdminPagesModel.java @@ -81,7 +81,7 @@ public class AdminPagesModel { ); final AdminPageModel model = new AdminPageModel(); - model.setUriIdentifier(fromAdminPage.getUriIdentifier()); + model.setPageUri(fromAdminPage.getPageUri()); model.setLabel(labelBundle.getString(fromAdminPage.getLabelKey())); model.setDescription( descriptionBundle.getString( diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/applications/ApplicationsPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/applications/ApplicationsPage.java index f59dd840a..202e6f21d 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/applications/ApplicationsPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/applications/ApplicationsPage.java @@ -58,11 +58,8 @@ public class ApplicationsPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getApplicationTypes", - ApplicationsController.class.getSimpleName() - ); + public String getPageUri() { + return "/applications"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/categories/CategoriesPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/categories/CategoriesPage.java index d4594658d..5259236b4 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/categories/CategoriesPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/categories/CategoriesPage.java @@ -46,11 +46,8 @@ public class CategoriesPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getCategorySystems", - CategorySystemsController.class.getSimpleName() - ); + public String getPageUri() { + return "/categorymanager/categorysystems"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/configuration/ConfigurationPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/configuration/ConfigurationPage.java index 1b0020b94..b23c94971 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/configuration/ConfigurationPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/configuration/ConfigurationPage.java @@ -44,10 +44,8 @@ public class ConfigurationPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getSettings", ConfigurationController.class.getSimpleName() - ); + public String getPageUri() { + return "/configuration"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/dashboard/DashboardPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/dashboard/DashboardPage.java index 42dde7292..25690d1d7 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/dashboard/DashboardPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/dashboard/DashboardPage.java @@ -42,10 +42,8 @@ public class DashboardPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getDashboard", DashboardController.class.getSimpleName() - ); + public String getPageUri() { + return "/"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/imexport/ImExportPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/imexport/ImExportPage.java index 2b00defd0..9f7f56019 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/imexport/ImExportPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/imexport/ImExportPage.java @@ -41,10 +41,8 @@ public class ImExportPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getImExportDashboard", ImExportController.class.getSimpleName() - ); + public String getPageUri() { + return "/imexport"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/sites/SitesPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/sites/SitesPage.java index d9f85c4c9..11b78bbbc 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/sites/SitesPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/sites/SitesPage.java @@ -42,10 +42,8 @@ public class SitesPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getSites", SitesController.class.getSimpleName() - ); + public String getPageUri() { + return "/sites"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationController.java b/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationController.java index 97e038520..d9700a5c0 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationController.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationController.java @@ -23,9 +23,7 @@ import org.libreccm.security.AuthorizationRequired; import org.libreccm.security.RequiresPrivilege; import javax.enterprise.context.RequestScoped; -import javax.inject.Inject; import javax.mvc.Controller; -import javax.mvc.MvcContext; import javax.ws.rs.GET; import javax.ws.rs.Path; diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationPage.java index 151aceff4..783300fed 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/systeminformation/SystemInformationPage.java @@ -42,11 +42,8 @@ public class SystemInformationPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getSystemInformation", - SystemInformationController.class.getSimpleName() - ); + public String getPageUri() { + return "/systeminformation"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/themes/ThemesPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/themes/ThemesPage.java index bcee4b564..d01e7b8cb 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/themes/ThemesPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/themes/ThemesPage.java @@ -42,10 +42,8 @@ public class ThemesPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getThemes", ThemesController.class.getSimpleName() - ); + public String getPageUri() { + return "/themes"; } @Override diff --git a/ccm-core/src/main/java/org/libreccm/ui/admin/usersgroupsroles/UsersGroupsRolesPage.java b/ccm-core/src/main/java/org/libreccm/ui/admin/usersgroupsroles/UsersGroupsRolesPage.java index 0b3e39d9c..3d9e3e2b0 100644 --- a/ccm-core/src/main/java/org/libreccm/ui/admin/usersgroupsroles/UsersGroupsRolesPage.java +++ b/ccm-core/src/main/java/org/libreccm/ui/admin/usersgroupsroles/UsersGroupsRolesPage.java @@ -53,11 +53,8 @@ public class UsersGroupsRolesPage implements AdminPage { } @Override - public String getUriIdentifier() { - return String.format( - "%s#getOverview", - UsersGroupsRolesController.class.getSimpleName() - ); + public String getPageUri() { + return "/users-groups-roles"; } @Override diff --git a/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/categories/categorysystem-details.xhtml b/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/categories/categorysystem-details.xhtml index afcdba4fb..6af02917b 100644 --- a/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/categories/categorysystem-details.xhtml +++ b/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/categories/categorysystem-details.xhtml @@ -13,7 +13,7 @@ @@ -80,7 +80,7 @@
+ href="#{mvc.basePath}/#{mvc.basePath}/categorymanager/categorysystems/#{CategorySystemDetailsModel.identifier}/edit"> #{AdminMessages['categorysystems.details.edit']} @@ -157,7 +157,7 @@ #{AdminMessages['categorysystems.details.owners.heading']}
-
+ href="#{mvc.basePath}/categorymanager/categories/#{CategorySystemsIdentifier.rootIdentifier}/subcategories/new"> #{AdminMessages['categorysystems.details.categories.add']} @@ -346,7 +346,7 @@ var="category"> - + #{category.name} @@ -382,7 +382,7 @@ -
- @@ -53,7 +53,7 @@
+ href="#{mvc.basePath}/sites/#{SiteDetailsModel.identifier}/edit"> #{AdminMessages['site.details.edit']} diff --git a/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/sites/site-form.xhtml b/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/sites/site-form.xhtml index 1d06f31e8..5cb3ac897 100644 --- a/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/sites/site-form.xhtml +++ b/ccm-core/src/main/resources/WEB-INF/views/org/libreccm/ui/admin/sites/site-form.xhtml @@ -11,7 +11,7 @@ @@ -23,7 +23,7 @@ @@ -47,7 +47,7 @@ - + href="#{SiteDetailsModel.new ? mvc.basePath += '/sites' : mvc.basePath += '/sites/' += SiteDetailsModel.identifier += '/details'}"> #{AdminMessages['sites.form.buttons.cancel']}