[CCM][UPDATE]

- modifies import test with output message of selected group to check members
- changes RoleMembershipMarshaller's insertIntoDb-method

git-svn-id: https://svn.libreccm.org/ccm/ccm_ng@4826 8810af33-2d31-482b-a856-94f89814c4df

Former-commit-id: cb4da653cd
pull/2/head
tosmers 2017-06-29 18:33:11 +00:00
parent f3944be6fe
commit 914bc340e3
4 changed files with 30 additions and 5 deletions

View File

@ -28,7 +28,6 @@ import javax.enterprise.context.RequestScoped;
* @author <a href="mailto:tosmers@uni-bremen.de>Tobias Osmers</a> * @author <a href="mailto:tosmers@uni-bremen.de>Tobias Osmers</a>
* @version created on 3/23/17 * @version created on 3/23/17
*/ */
@RequestScoped
public class CategoryIdResolver implements ObjectIdResolver { public class CategoryIdResolver implements ObjectIdResolver {
@Override @Override

View File

@ -44,8 +44,9 @@ public class GroupMembershipMarshaller extends AbstractMarshaller<GroupMembershi
@Override @Override
@Transactional(Transactional.TxType.REQUIRED) @Transactional(Transactional.TxType.REQUIRED)
protected void insertIntoDb(GroupMembership portableObject) { protected void insertIntoDb(final GroupMembership portableObject) {
portableObject.setMembershipId(portableObject.getMembershipId() * -1); portableObject.setMembershipId(portableObject.getMembershipId() * -1);
entityManager.merge(portableObject); entityManager.merge(portableObject);
entityManager.flush();
} }
} }

View File

@ -46,7 +46,7 @@ public class RoleMembershipMarshaller extends AbstractMarshaller<RoleMembership>
return RoleMembership.class; return RoleMembership.class;
} }
@Override /*@Override
// @Transactional(Transactional.TxType.REQUIRED) // @Transactional(Transactional.TxType.REQUIRED)
protected void insertIntoDb(final RoleMembership portableObject) { protected void insertIntoDb(final RoleMembership portableObject) {
@ -60,11 +60,19 @@ public class RoleMembershipMarshaller extends AbstractMarshaller<RoleMembership>
LOGGER.debug("Saved RoleMembership with id {}.", LOGGER.debug("Saved RoleMembership with id {}.",
roleMembership.getMembershipId()); roleMembership.getMembershipId());
} }
@Transactional(Transactional.TxType.REQUIRES_NEW) @Transactional(Transactional.TxType.REQUIRES_NEW)
protected RoleMembership save(final RoleMembership membership) { protected RoleMembership save(final RoleMembership membership) {
entityManager.persist(membership); entityManager.persist(membership);
return membership; return membership;
}*/
@Override
@Transactional(Transactional.TxType.REQUIRED)
protected void insertIntoDb(final RoleMembership portableObject) {
portableObject.setMembershipId(portableObject.getMembershipId() * -1);
entityManager.merge(portableObject);
entityManager.flush();
} }
} }

View File

@ -33,10 +33,14 @@ import org.jboss.shrinkwrap.api.spec.WebArchive;
import org.junit.*; import org.junit.*;
import org.junit.experimental.categories.Category; import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.libreccm.security.Group;
import org.libreccm.security.GroupRepository;
import org.libreccm.tests.categories.IntegrationTest; import org.libreccm.tests.categories.IntegrationTest;
import javax.inject.Inject; import javax.inject.Inject;
import java.util.concurrent.TimeUnit;
import static org.libreccm.testutils.DependenciesHelpers.getModuleDependencies; import static org.libreccm.testutils.DependenciesHelpers.getModuleDependencies;
@ -58,6 +62,8 @@ public class CoreDataImportTest {
@Inject @Inject
private ImportHelper importHelper; private ImportHelper importHelper;
@Inject
private GroupRepository groupRepository;
public CoreDataImportTest() { public CoreDataImportTest() {
@ -124,13 +130,24 @@ public class CoreDataImportTest {
@Test @Test
@InSequence(100) @InSequence(100)
public void objectsShouldBeImported() { public void objectsShouldBeImported() throws InterruptedException {
// assert for no errors // assert for no errors
Assert.assertFalse(importHelper.importUsers()); Assert.assertFalse(importHelper.importUsers());
Assert.assertFalse(importHelper.importGroups()); Assert.assertFalse(importHelper.importGroups());
Assert.assertFalse(importHelper.importGroupMemberships()); Assert.assertFalse(importHelper.importGroupMemberships());
Assert.assertFalse(importHelper.importRoles()); Assert.assertFalse(importHelper.importRoles());
Assert.assertFalse(importHelper.importRoleMemberships()); Assert.assertFalse(importHelper.importRoleMemberships());
final String name = "research_Administration_Publisher";
Group group = groupRepository
.findByName(name)
.orElseThrow(() -> new IllegalArgumentException(String
.format("No Group fount with the name: %s", name)));
System.err.println(group.toString());
//Assert.assertFalse(importHelper.importCategories()); //Assert.assertFalse(importHelper.importCategories());
} }