Fixed some test failures

git-svn-id: https://svn.libreccm.org/ccm/ccm_ng@5883 8810af33-2d31-482b-a856-94f89814c4df
jensp 2019-03-26 20:39:10 +00:00
parent 51b7cb3f1a
commit b1305b8d4c
17 changed files with 42 additions and 26 deletions

View File

@ -130,6 +130,7 @@ public class CategoryRepositoryTest {
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(com.arsdigita.kernel.KernelConfig.class) .addClass(com.arsdigita.kernel.KernelConfig.class)
.addClass(com.arsdigita.kernel.security.SecurityConfig.class) .addClass(com.arsdigita.kernel.security.SecurityConfig.class)
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("configs/shiro.ini", "shiro.ini") .addAsResource("configs/shiro.ini", "shiro.ini")
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",

View File

@ -120,6 +120,7 @@ public class ConfigurationManagerTest {
.addClass(com.example.TestConfiguration.class) .addClass(com.example.TestConfiguration.class)
.addClass(com.arsdigita.kernel.KernelConfig.class) .addClass(com.arsdigita.kernel.KernelConfig.class)
.addClass(com.arsdigita.kernel.security.SecurityConfig.class) .addClass(com.arsdigita.kernel.security.SecurityConfig.class)
.addClass(org.libreccm.imexport.Exportable.class)
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("configs/shiro.ini", "shiro.ini") .addAsResource("configs/shiro.ini", "shiro.ini")

View File

@ -188,21 +188,21 @@ public class CcmObjectRepositoryTest {
@UsingDataSet("datasets/org/libreccm/core/CcmObjectRepositoryTest/data.yml") @UsingDataSet("datasets/org/libreccm/core/CcmObjectRepositoryTest/data.yml")
@InSequence(5) @InSequence(5)
public void entityManagerFindCcmObjectByLongPrimitive() { public void entityManagerFindCcmObjectByLongPrimitive() {
final CcmObject obj1 = entityManager.find(CcmObject.class, -10L); final CcmObject obj1 = entityManager.find(CcmObject.class, 10L);
final CcmObject obj2 = entityManager.find(CcmObject.class, -20L); final CcmObject obj2 = entityManager.find(CcmObject.class, 20L);
final CcmObject obj3 = entityManager.find(CcmObject.class, -30L); final CcmObject obj3 = entityManager.find(CcmObject.class, 30L);
final CcmObject none = entityManager.find(CcmObject.class, -999L); final CcmObject none = entityManager.find(CcmObject.class, 999L);
assertThat(obj1, is(not(nullValue()))); assertThat(obj1, is(not(nullValue())));
assertThat(obj1.getObjectId(), is(-10L)); assertThat(obj1.getObjectId(), is(10L));
assertThat(obj1.getDisplayName(), is(equalTo("Test Object 1"))); assertThat(obj1.getDisplayName(), is(equalTo("Test Object 1")));
assertThat(obj2, is(not(nullValue()))); assertThat(obj2, is(not(nullValue())));
assertThat(obj2.getObjectId(), is(-20L)); assertThat(obj2.getObjectId(), is(20L));
assertThat(obj2.getDisplayName(), is(equalTo("Test Object 2"))); assertThat(obj2.getDisplayName(), is(equalTo("Test Object 2")));
assertThat(obj3, is(not(nullValue()))); assertThat(obj3, is(not(nullValue())));
assertThat(obj3.getObjectId(), is(-30L)); assertThat(obj3.getObjectId(), is(30L));
assertThat(obj3.getDisplayName(), is(equalTo("Test Object 3"))); assertThat(obj3.getDisplayName(), is(equalTo("Test Object 3")));
assertThat(none, is(nullValue())); assertThat(none, is(nullValue()));
@ -217,10 +217,10 @@ public class CcmObjectRepositoryTest {
@UsingDataSet("datasets/org/libreccm/core/CcmObjectRepositoryTest/data.yml") @UsingDataSet("datasets/org/libreccm/core/CcmObjectRepositoryTest/data.yml")
@InSequence(6) @InSequence(6)
public void entityManagerFindCcmObjectByLongClass() { public void entityManagerFindCcmObjectByLongClass() {
final Long id1 = -10L; final Long id1 = 10L;
final Long id2 = -20L; final Long id2 = 20L;
final Long id3 = -30L; final Long id3 = 30L;
final Long id4 = -999L; final Long id4 = 999L;
final CcmObject obj1 = entityManager.find(CcmObject.class, id1); final CcmObject obj1 = entityManager.find(CcmObject.class, id1);
final CcmObject obj2 = entityManager.find(CcmObject.class, id2); final CcmObject obj2 = entityManager.find(CcmObject.class, id2);
@ -228,15 +228,15 @@ public class CcmObjectRepositoryTest {
final CcmObject none = entityManager.find(CcmObject.class, id4); final CcmObject none = entityManager.find(CcmObject.class, id4);
assertThat(obj1, is(not(nullValue()))); assertThat(obj1, is(not(nullValue())));
assertThat(obj1.getObjectId(), is(-10L)); assertThat(obj1.getObjectId(), is(10L));
assertThat(obj1.getDisplayName(), is(equalTo("Test Object 1"))); assertThat(obj1.getDisplayName(), is(equalTo("Test Object 1")));
assertThat(obj2, is(not(nullValue()))); assertThat(obj2, is(not(nullValue())));
assertThat(obj2.getObjectId(), is(-20L)); assertThat(obj2.getObjectId(), is(20L));
assertThat(obj2.getDisplayName(), is(equalTo("Test Object 2"))); assertThat(obj2.getDisplayName(), is(equalTo("Test Object 2")));
assertThat(obj3, is(not(nullValue()))); assertThat(obj3, is(not(nullValue())));
assertThat(obj3.getObjectId(), is(-30L)); assertThat(obj3.getObjectId(), is(30L));
assertThat(obj3.getDisplayName(), is(equalTo("Test Object 3"))); assertThat(obj3.getDisplayName(), is(equalTo("Test Object 3")));
assertThat(none, is(nullValue())); assertThat(none, is(nullValue()));
@ -246,21 +246,21 @@ public class CcmObjectRepositoryTest {
@UsingDataSet("datasets/org/libreccm/core/CcmObjectRepositoryTest/data.yml") @UsingDataSet("datasets/org/libreccm/core/CcmObjectRepositoryTest/data.yml")
@InSequence(10) @InSequence(10)
public void findCcmObjectById() { public void findCcmObjectById() {
final Optional<CcmObject> obj1 = ccmObjectRepository.findById(-10L); final Optional<CcmObject> obj1 = ccmObjectRepository.findById(10L);
final Optional<CcmObject> obj2 = ccmObjectRepository.findById(-20L); final Optional<CcmObject> obj2 = ccmObjectRepository.findById(20L);
final Optional<CcmObject> obj3 = ccmObjectRepository.findById(-30L); final Optional<CcmObject> obj3 = ccmObjectRepository.findById(30L);
final Optional<CcmObject> none = ccmObjectRepository.findById(-999L); final Optional<CcmObject> none = ccmObjectRepository.findById(999L);
assertThat(obj1.isPresent(), is(true)); assertThat(obj1.isPresent(), is(true));
assertThat(obj1.get().getObjectId(), is(-10L)); assertThat(obj1.get().getObjectId(), is(10L));
assertThat(obj1.get().getDisplayName(), is(equalTo("Test Object 1"))); assertThat(obj1.get().getDisplayName(), is(equalTo("Test Object 1")));
assertThat(obj2.isPresent(), is(true)); assertThat(obj2.isPresent(), is(true));
assertThat(obj2.get().getObjectId(), is(-20L)); assertThat(obj2.get().getObjectId(), is(20L));
assertThat(obj2.get().getDisplayName(), is(equalTo("Test Object 2"))); assertThat(obj2.get().getDisplayName(), is(equalTo("Test Object 2")));
assertThat(obj3.isPresent(), is(true)); assertThat(obj3.isPresent(), is(true));
assertThat(obj3.get().getObjectId(), is(-30L)); assertThat(obj3.get().getObjectId(), is(30L));
assertThat(obj3.get().getDisplayName(), is(equalTo("Test Object 3"))); assertThat(obj3.get().getDisplayName(), is(equalTo("Test Object 3")));
assertThat(none.isPresent(), is(false)); assertThat(none.isPresent(), is(false));
@ -312,7 +312,7 @@ public class CcmObjectRepositoryTest {
excludeColumns = {"object_id"}) excludeColumns = {"object_id"})
@InSequence(400) @InSequence(400)
public void saveChangedCcmObject() { public void saveChangedCcmObject() {
final CcmObject obj = ccmObjectRepository.findById(-20L).get(); final CcmObject obj = ccmObjectRepository.findById(20L).get();
obj.setDisplayName("Second Test Object"); obj.setDisplayName("Second Test Object");
ccmObjectRepository.save(obj); ccmObjectRepository.save(obj);
@ -343,7 +343,7 @@ public class CcmObjectRepositoryTest {
excludeColumns = {"object_id"}) excludeColumns = {"object_id"})
@InSequence(600) @InSequence(600)
public void deleteCcmObject() { public void deleteCcmObject() {
final CcmObject obj = ccmObjectRepository.findById(-20L).get(); final CcmObject obj = ccmObjectRepository.findById(20L).get();
ccmObjectRepository.delete(obj); ccmObjectRepository.delete(obj);
} }

View File

@ -130,6 +130,7 @@ public class AuthorizationInterceptorTest {
.getPackage()) .getPackage())
.addClass(com.arsdigita.kernel.KernelConfig.class) .addClass(com.arsdigita.kernel.KernelConfig.class)
.addClass(com.arsdigita.util.UncheckedWrapperException.class) .addClass(com.arsdigita.util.UncheckedWrapperException.class)
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -123,6 +123,7 @@ public class GroupManagerTest {
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(com.arsdigita.kernel.KernelConfig.class) .addClass(com.arsdigita.kernel.KernelConfig.class)
.addClass(com.arsdigita.kernel.security.SecurityConfig.class) .addClass(com.arsdigita.kernel.security.SecurityConfig.class)
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -123,6 +123,7 @@ public class GroupRepositoryTest {
.getPackage()) .getPackage())
.addPackage(org.libreccm.tests.categories.IntegrationTest.class .addPackage(org.libreccm.tests.categories.IntegrationTest.class
.getPackage()) .getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("configs/shiro.ini", "shiro.ini") .addAsResource("configs/shiro.ini", "shiro.ini")
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",

View File

@ -127,6 +127,7 @@ public class OneTimeAuthManagerTest {
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(com.arsdigita.kernel.KernelConfig.class) .addClass(com.arsdigita.kernel.KernelConfig.class)
.addClass(com.arsdigita.kernel.security.SecurityConfig.class) .addClass(com.arsdigita.kernel.security.SecurityConfig.class)
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("configs/shiro.ini", "shiro.ini") .addAsResource("configs/shiro.ini", "shiro.ini")
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",

View File

@ -128,6 +128,7 @@ public class PartyRepositoryTest {
.addClass(com.arsdigita.kernel.security.SecurityConfig.class) .addClass(com.arsdigita.kernel.security.SecurityConfig.class)
.addClass(com.arsdigita.kernel.KernelConfig.class) .addClass(com.arsdigita.kernel.KernelConfig.class)
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("configs/shiro.ini", "shiro.ini") .addAsResource("configs/shiro.ini", "shiro.ini")
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",

View File

@ -131,6 +131,7 @@ public class PermissionCheckerTest {
.getPackage()) .getPackage())
.addPackage(com.arsdigita.kernel.security.SecurityConfig.class .addPackage(com.arsdigita.kernel.security.SecurityConfig.class
.getPackage()) .getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -128,10 +128,11 @@ public class PermissionManagerTest {
.getPackage()) .getPackage())
.addPackage(org.libreccm.web.CcmApplication.class.getPackage()) .addPackage(org.libreccm.web.CcmApplication.class.getPackage())
.addPackage(org.libreccm.workflow.Workflow.class.getPackage()) .addPackage(org.libreccm.workflow.Workflow.class.getPackage())
.addPackage(com.arsdigita.kernel.KernelConfig.class.getPackage()). .addPackage(com.arsdigita.kernel.KernelConfig.class.getPackage())
addPackage(com.arsdigita.kernel.security.SecurityConfig.class .addPackage(com.arsdigita.kernel.security.SecurityConfig.class
.getPackage()) .getPackage())
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")
@ -610,7 +611,7 @@ public class PermissionManagerTest {
*/ */
@Test(expected = IllegalArgumentException.class) @Test(expected = IllegalArgumentException.class)
@UsingDataSet("datasets/org/libreccm/security/PermissionManagerTest/" @UsingDataSet("datasets/org/libreccm/security/PermissionManagerTest/"
+ "data.yml") + "data.yml")
@ShouldThrowException(IllegalArgumentException.class) @ShouldThrowException(IllegalArgumentException.class)
@InSequence(340) @InSequence(340)
public void revokePermissionFromRoleNull() throws Throwable { public void revokePermissionFromRoleNull() throws Throwable {

View File

@ -120,6 +120,7 @@ public class RoleManagerTest {
.addPackage(com.arsdigita.kernel.security.SecurityConfig.class .addPackage(com.arsdigita.kernel.security.SecurityConfig.class
.getPackage()) .getPackage())
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -129,6 +129,7 @@ public class RoleRepositoryTest {
getPackage()) getPackage())
.addPackage(org.libreccm.tests.categories.IntegrationTest.class .addPackage(org.libreccm.tests.categories.IntegrationTest.class
.getPackage()) .getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("configs/shiro.ini", "shiro.ini") .addAsResource("configs/shiro.ini", "shiro.ini")
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",

View File

@ -147,6 +147,7 @@ public class SecuredCollectionTest {
.addPackage(com.arsdigita.kernel.KernelConfig.class.getPackage()) .addPackage(com.arsdigita.kernel.KernelConfig.class.getPackage())
.addPackage(com.arsdigita.kernel.security.SecurityConfig.class .addPackage(com.arsdigita.kernel.security.SecurityConfig.class
.getPackage()) .getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -149,6 +149,7 @@ public class SecuredIteratorTest {
.addPackage(com.arsdigita.kernel.security.SecurityConfig.class .addPackage(com.arsdigita.kernel.security.SecurityConfig.class
.getPackage()) .getPackage())
.addPackage(com.arsdigita.kernel.KernelConfig.class.getPackage()) .addPackage(com.arsdigita.kernel.KernelConfig.class.getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -122,6 +122,7 @@ public class ShiroTest {
.addPackage(com.arsdigita.kernel.security.SecurityConfig.class .addPackage(com.arsdigita.kernel.security.SecurityConfig.class
.getPackage()) .getPackage())
.addClass(org.libreccm.security.authorization.LabBean.class) .addClass(org.libreccm.security.authorization.LabBean.class)
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -123,6 +123,7 @@ public class UserManagerTest {
.addPackage(com.arsdigita.kernel.security.SecurityConfig.class .addPackage(com.arsdigita.kernel.security.SecurityConfig.class
.getPackage()) .getPackage())
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",
"META-INF/persistence.xml") "META-INF/persistence.xml")

View File

@ -128,6 +128,7 @@ public class UserRepositoryTest {
.addClass(com.arsdigita.kernel.security.SecurityConfig.class) .addClass(com.arsdigita.kernel.security.SecurityConfig.class)
.addClass(com.arsdigita.kernel.KernelConfig.class) .addClass(com.arsdigita.kernel.KernelConfig.class)
.addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage()) .addPackage(org.libreccm.cdi.utils.CdiUtil.class.getPackage())
.addClass(org.libreccm.imexport.Exportable.class)
.addAsLibraries(getModuleDependencies()) .addAsLibraries(getModuleDependencies())
.addAsResource("configs/shiro.ini", "shiro.ini") .addAsResource("configs/shiro.ini", "shiro.ini")
.addAsResource("test-persistence.xml", .addAsResource("test-persistence.xml",