CCM NG: Removed the javabeans PMD ruleset from the list of checked rulesets

because the rule "BeanMembersShouldSerialize" from this ruleset procduces many 
false positives. Also removed also usages of the transient modifier which 
were only added to various classes to match this rule.


git-svn-id: https://svn.libreccm.org/ccm/ccm_ng@3743 8810af33-2d31-482b-a856-94f89814c4df

ccm-archetype-module/src/main/resources/archetype-resources/pom.xml

@@ -277,7 +277,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-archetype-module/src/main/resources/archetype-resources/src/test/java/__moduleClass__Test.java

@@ -46,7 +46,7 @@ import static org.junit.Assert.*;
 public class ${moduleClass}Test {
 
     @PersistenceContext(name = "LibreCCM")
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     @BeforeClass
     public static void setUpClass() {

ccm-cms-archetype-contenttype/src/main/resources/archetype-resources/pom.xml

@@ -285,7 +285,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms-types-agenda/pom.xml

@@ -287,7 +287,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms-types-article/pom.xml

@@ -286,7 +286,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms-types-bookmark/pom.xml

@@ -287,7 +287,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms-types-decisiontree/pom.xml

@@ -287,7 +287,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms-types-event/pom.xml

@@ -287,7 +287,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms-types-minutes/pom.xml

@@ -287,7 +287,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms-types-mparticle/pom.xml

@@ -287,7 +287,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms/pom.xml

@@ -278,7 +278,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-cms/src/test/java/org/librecms/CmsTest.java

@@ -48,7 +48,7 @@ import static org.junit.Assert.*;
 public class CmsTest {
 
     @PersistenceContext(name = "LibreCCM")
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     @BeforeClass
     public static void setUpClass() {

ccm-core/pom.xml

@@ -409,7 +409,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-core/src/main/java/com/arsdigita/bebop/event/FormSectionEvent.java

@@ -36,7 +36,7 @@ import com.arsdigita.bebop.PageState;
  */
 public class FormSectionEvent extends PageEvent {
 
-    private final transient FormData _formData;
+    private final FormData _formData;
 
     /**
      * Get the form data for to the form that fired the event in the current

ccm-core/src/main/java/com/arsdigita/bebop/event/PageEvent.java

@@ -34,7 +34,7 @@ import java.util.EventObject;
  */
 public class PageEvent extends EventObject {
 
-    private transient PageState _state;
+    private PageState _state;
 
     /**
      * Construct a new <code>PageEvent</code>.

ccm-core/src/main/java/com/arsdigita/bebop/event/ParameterEvent.java

@@ -38,8 +38,8 @@ import java.util.EventObject;
 public class ParameterEvent extends EventObject {
 
     /* The request specific data about the event */
-    private transient ParameterData m_data;
-    private transient PageState m_state;
+    private ParameterData m_data;
+    private PageState m_state;
 
     /**
      * Construct a <code>ParameterEvent</code>

ccm-core/src/main/java/com/arsdigita/web/CCMDispatcherServlet.java

@@ -65,7 +65,7 @@ public class CCMDispatcherServlet extends BaseServlet {
     private static String s_contextPath;
 
     @Inject
-    private transient ApplicationRepository appRepository;
+    private ApplicationRepository appRepository;
 
     /**
      * Servlet initializer uses the extension point of parent class.

ccm-core/src/main/java/org/libreccm/auditing/AbstractAuditedEntityRepository.java

@@ -35,7 +35,7 @@ public abstract class AbstractAuditedEntityRepository<K, T>
     extends AbstractEntityRepository<K, T> {
 
     @Inject
-    private transient AuditReader auditReader;
+    private AuditReader auditReader;
 
     public abstract K getEntityId(final T entity);
 

ccm-core/src/main/java/org/libreccm/auditing/CcmRevisionListener.java

@@ -29,9 +29,6 @@ import javax.inject.Inject;
  */
 public class CcmRevisionListener implements RevisionListener {
 
-//    @Inject
-//    private transient CcmSessionContext sessionContext;
-
     @Override
     public void newRevision(final Object revisionEntity) {
         if (!(revisionEntity instanceof CcmRevision)) {

ccm-core/src/main/java/org/libreccm/categorization/CategoryManager.java

@@ -36,7 +36,7 @@ public class CategoryManager {
      * A {@link CategoryRepository} instance used to interact with the database.
      */
     @Inject
-    private transient CategoryRepository categoryRepo;
+    private CategoryRepository categoryRepo;
 
     /**
      * Assigns an category to an object. The object is added at the position

ccm-core/src/main/java/org/libreccm/categorization/DomainManager.java

@@ -33,7 +33,7 @@ import javax.inject.Inject;
 public class DomainManager {
 
     @Inject
-    private transient DomainRepository domainRepo;
+    private DomainRepository domainRepo;
 
     /**
      * Adds a {@code CcmApplication} to the owners of a {@link Domain}. If the

ccm-core/src/main/java/org/libreccm/categorization/DomainRepository.java

@@ -35,7 +35,7 @@ import javax.persistence.EntityManager;
 public class DomainRepository extends AbstractEntityRepository<Long, Domain> {
 
     @Inject
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
     
     @Override
     public Class<Domain> getEntityClass() {

ccm-core/src/main/java/org/libreccm/cdi/utils/CdiUtil.java

@@ -38,7 +38,7 @@ public class CdiUtil {
 
     private final static Logger LOGGER = LogManager.getLogger(CdiUtil.class);
 
-    private final transient BeanManager beanManager;
+    private final BeanManager beanManager;
 
     public CdiUtil() {
         beanManager = CDI.current().getBeanManager();

ccm-core/src/main/java/org/libreccm/core/AbstractEntityRepository.java

@@ -42,7 +42,7 @@ public abstract class AbstractEntityRepository<K, E> {
      * CDI.
      */
     @Inject
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     /**
      * Getter method for retrieving the injected {@link EntityManager}.

ccm-core/src/main/java/org/libreccm/jpa/AuditReaderProducer.java

@@ -32,7 +32,7 @@ import javax.persistence.EntityManager;
 public class AuditReaderProducer {
     
     @Inject
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
     
     @Produces
     public AuditReader auditReader() {

ccm-core/src/main/java/org/libreccm/modules/CcmModuleContextListener.java

@@ -42,7 +42,7 @@ public class CcmModuleContextListener implements ServletContextListener {
             CcmModuleContextListener.class);
 
     @Inject
-    private transient ModuleManager moduleManager;
+    private ModuleManager moduleManager;
 
     @Override
     public void contextInitialized(final ServletContextEvent event) {

ccm-core/src/main/java/org/libreccm/modules/ModuleInfo.java

@@ -57,23 +57,23 @@ public class ModuleInfo {
     /**
      * The name of the module (artifact id).
      */
-    private transient String moduleName;
+    private String moduleName;
     /**
      * The data package of the module (group id).
      */
-    private transient String moduleDataPackage;
+    private String moduleDataPackage;
     /**
      * The entities provided by the module.
      */
-    private transient Class<?>[] moduleEntities;
+    private Class<?>[] moduleEntities;
     /**
      * The version of the module.
      */
-    private transient String moduleVersion;
+    private String moduleVersion;
     /**
      * The modules required by the described module.
      */
-    private transient RequiredModule[] requiredModules;
+    private RequiredModule[] requiredModules;
 
     public ModuleInfo() {
         //Nothing

ccm-core/src/main/java/org/libreccm/security/PermissionChecker.java

@@ -38,10 +38,10 @@ public class PermissionChecker {
      * The current subject as provided by {@link Shiro#getSubject()}.
      */
     @Inject
-    private transient Subject subject;
+    private Subject subject;
 
     @Inject
-    private transient Shiro shiro;
+    private Shiro shiro;
 
     /**
      * Checks if the current subject has a permission granting the provided

ccm-core/src/main/java/org/libreccm/web/ApplicationManager.java

@@ -42,7 +42,7 @@ import javax.servlet.http.HttpServlet;
 public class ApplicationManager {
 
     @Inject
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     private Map<String, ApplicationType> applicationTypes;
 

ccm-core/src/test/java/org/libreccm/core/CcmObjectRepositoryTest.java

@@ -65,10 +65,10 @@ import static org.junit.Assert.*;
 public class CcmObjectRepositoryTest {
     
     @Inject
-    private transient CcmObjectRepository ccmObjectRepository;
+    private CcmObjectRepository ccmObjectRepository;
     
     @PersistenceContext(name = "LibreCCM")
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
     
     public CcmObjectRepositoryTest() {
     }

ccm-core/src/test/java/org/libreccm/jpautils/MimeTypeConverterTest.java

@@ -49,7 +49,7 @@ public class MimeTypeConverterTest {
     public static final String VIDEO_MP4
                                = "video/mp4";
 
-    private transient MimeTypeConverter mimeTypeConverter;
+    private MimeTypeConverter mimeTypeConverter;
     
     public MimeTypeConverterTest() {
     }

ccm-core/src/test/java/org/libreccm/jpautils/UriConverterTest.java

@@ -53,7 +53,7 @@ public class UriConverterTest {
     private static final String HTTP = "http";
     private static final String FILE = "file";
 
-    private transient UriConverter uriConverter;
+    private UriConverter uriConverter;
 
     public UriConverterTest() {
     }

ccm-core/src/test/java/org/libreccm/modules/DependencyTreeManagerCycleTest.java

@@ -58,7 +58,7 @@ import java.util.List;
 @RunWith(Arquillian.class)
 public class DependencyTreeManagerCycleTest {
 
-    private transient Iterable<CcmModule> modules;
+    private Iterable<CcmModule> modules;
 
     public DependencyTreeManagerCycleTest() {
     }

ccm-core/src/test/java/org/libreccm/modules/DependencyTreeManagerTest.java

@@ -57,7 +57,7 @@ import java.util.List;
 @RunWith(Arquillian.class)
 public class DependencyTreeManagerTest {
 
-    private transient Iterable<CcmModule> modules;
+    private Iterable<CcmModule> modules;
 
     public DependencyTreeManagerTest() {
     }

ccm-core/src/test/java/org/libreccm/security/GroupRepositoryTest.java

@@ -74,10 +74,10 @@ public class GroupRepositoryTest {
     private static final String NONE = "none";
 
     @Inject
-    private transient GroupRepository groupRepository;
+    private GroupRepository groupRepository;
 
     @PersistenceContext
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     public GroupRepositoryTest() {
 

ccm-core/src/test/java/org/libreccm/security/PartyRepositoryTest.java

@@ -75,10 +75,10 @@ public class PartyRepositoryTest {
     private static final String MANAGERS = "managers";
 
     @Inject
-    private transient PartyRepository partyRepository;
+    private PartyRepository partyRepository;
 
     @PersistenceContext
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     public PartyRepositoryTest() {
     }

ccm-core/src/test/java/org/libreccm/security/PermissionCheckerTest.java

@@ -79,16 +79,16 @@ import static org.junit.Assert.*;
 public class PermissionCheckerTest {
 
     @Inject
-    private transient Subject subject;
+    private Subject subject;
 
     @Inject
-    private transient Shiro shiro;
+    private Shiro shiro;
 
     @Inject
-    private transient PermissionChecker permissionChecker;
+    private PermissionChecker permissionChecker;
 
     @Inject
-    private transient CcmObjectRepository objectRepository;
+    private CcmObjectRepository objectRepository;
 
     public PermissionCheckerTest() {
     }

ccm-core/src/test/java/org/libreccm/security/RoleRepositoryTest.java

@@ -72,10 +72,10 @@ public class RoleRepositoryTest {
     private static final String READER = "reader";
 
     @Inject
-    private transient RoleRepository roleRepository;
+    private RoleRepository roleRepository;
 
     @PersistenceContext
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     public RoleRepositoryTest() {
     }

ccm-core/src/test/java/org/libreccm/security/UserRepositoryTest.java

@@ -77,10 +77,10 @@ public class UserRepositoryTest {
     private static final String JDOE = "jdoe";
 
     @Inject
-    private transient UserRepository userRepository;
+    private UserRepository userRepository;
 
     @PersistenceContext
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     public UserRepositoryTest() {
     }

ccm-docrepo/pom.xml

@@ -282,7 +282,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-docrepo/src/main/java/org/libreccm/docrepo/ResourceManager.java

@@ -34,7 +34,7 @@ public class ResourceManager {
     private static final Logger log = Logger.getLogger(ResourceManager.class);
 
     @Inject
-    private transient ResourceRepository resourceRepository;
+    private ResourceRepository resourceRepository;
 
     public void copyToFolder(Resource original, Folder folder) {
         Resource copy = original.isFolder() ? new Folder() : new File();

ccm-docrepo/src/main/java/org/libreccm/docrepo/ResourceRepository.java

@@ -39,7 +39,7 @@ import java.util.List;
 public class ResourceRepository extends AbstractAuditedEntityRepository<Long, Resource> {
 
     @Inject
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     @Override
     public Long getEntityId(Resource entity) {

ccm-shortcuts/pom.xml

@@ -292,7 +292,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-shortcuts/src/main/java/org/libreccm/shortcuts/ShortcutManager.java

@@ -38,7 +38,7 @@ public class ShortcutManager {
      * {@link ShortcutRepository} for interacting with the database.
      */
     @Inject
-    private transient ShortcutRepository shortcutRepository;
+    private ShortcutRepository shortcutRepository;
 
     /**
      * Creates a Shortcut

ccm-test-bundle-wildfly8/pom.xml

@@ -279,7 +279,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
                         <ruleset>/rulesets/java/junit.xml</ruleset>
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>

ccm-test-bundle-wildfly8/src/test/java/org/libreccm/CcmModulesTest.java

@@ -74,7 +74,7 @@ import javax.persistence.TypedQuery;
 public class CcmModulesTest {
 
     @PersistenceContext(name = "LibreCCM")
-    private transient EntityManager entityManager;
+    private EntityManager entityManager;
 
     public CcmModulesTest() {
 

ccm-testutils/pom.xml

@@ -144,8 +144,6 @@
                         <ruleset>/rulesets/java/empty.xml</ruleset>
                         <ruleset>/rulesets/java/finalizers.xml</ruleset>
                         <ruleset>/rulesets/java/imports.xml</ruleset>
-                        <ruleset>/rulesets/java/javabeans.xml</ruleset>
-                        <!--<ruleset>/rulesets/java/junit.xml</ruleset>-->
                         <ruleset>/rulesets/java/naming.xml</ruleset>
                         <ruleset>/rulesets/java/optimizations.xml</ruleset>
                         <ruleset>/rulesets/java/strictexception.xml</ruleset>

ccm-testutils/src/main/java/org/libreccm/testutils/DatasetsVerifier.java

@@ -72,7 +72,7 @@ import java.nio.charset.StandardCharsets;
  */
 public class DatasetsVerifier {
 
-    private final transient String datasetPath;
+    private final String datasetPath;
 
     public DatasetsVerifier(final String datasetsPath) {
         this.datasetPath = datasetsPath;

ccm-testutils/src/main/java/org/libreccm/testutils/EqualsVerifier.java

@@ -68,7 +68,7 @@ import org.junit.runners.Parameterized;
  */
 public class EqualsVerifier {
     
-    private final transient Class<?> entityClass;
+    private final Class<?> entityClass;
     
     public EqualsVerifier(final Class<?> entityClass) {
         this.entityClass = entityClass;

ccm-testutils/src/main/java/org/libreccm/testutils/ToStringVerifier.java

@@ -62,7 +62,7 @@ import java.lang.reflect.Modifier;
  */
 public class ToStringVerifier {
     
-    private final transient Class<?> entityClass;
+    private final Class<?> entityClass;
     
     public ToStringVerifier(final Class<?> entityClass) {
         this.entityClass = entityClass;