CCM NG: All tests in ccm-core now pass again

git-svn-id: https://svn.libreccm.org/ccm/ccm_ng@5888 8810af33-2d31-482b-a856-94f89814c4df
pull/2/head
jensp 2019-03-28 18:05:21 +00:00
parent de2b9755d0
commit c1195e0405
6 changed files with 45 additions and 24 deletions

View File

@ -27,6 +27,7 @@ import java.util.Set;
import javax.enterprise.context.RequestScoped; import javax.enterprise.context.RequestScoped;
import javax.inject.Inject; import javax.inject.Inject;
import javax.persistence.EntityManager;
import javax.transaction.Transactional; import javax.transaction.Transactional;
/** /**
@ -35,7 +36,10 @@ import javax.transaction.Transactional;
*/ */
@RequestScoped @RequestScoped
@Processes(Group.class) @Processes(Group.class)
public class GroupImExporter extends AbstractEntityImExporter<Group>{ public class GroupImExporter extends AbstractEntityImExporter<Group> {
@Inject
private EntityManager entityManager;
@Inject @Inject
private GroupRepository groupRepository; private GroupRepository groupRepository;
@ -50,7 +54,8 @@ public class GroupImExporter extends AbstractEntityImExporter<Group>{
protected void saveImportedEntity(final Group entity) { protected void saveImportedEntity(final Group entity) {
entity.setPartyId(0); entity.setPartyId(0);
groupRepository.save(entity); // groupRepository.save(entity);
entityManager.persist(entity);
} }
@Override @Override

View File

@ -367,6 +367,7 @@ public class PermissionManager implements Serializable {
permission.setObject(object); permission.setObject(object);
permission.setInherited(true); permission.setInherited(true);
permission.setInheritedFrom(inheritedFrom); permission.setInheritedFrom(inheritedFrom);
permission.setUuid(UUID.randomUUID().toString());
entityManager.persist(permission); entityManager.persist(permission);
@ -405,6 +406,7 @@ public class PermissionManager implements Serializable {
permission.setGrantee(grantee); permission.setGrantee(grantee);
permission.setGrantedPrivilege(privilege); permission.setGrantedPrivilege(privilege);
permission.setObject(null); permission.setObject(null);
permission.setUuid(UUID.randomUUID().toString());
entityManager.persist(permission); entityManager.persist(permission);
} }

View File

@ -27,6 +27,7 @@ import java.util.Set;
import javax.enterprise.context.RequestScoped; import javax.enterprise.context.RequestScoped;
import javax.inject.Inject; import javax.inject.Inject;
import javax.persistence.EntityManager;
import javax.transaction.Transactional; import javax.transaction.Transactional;
/** /**
@ -37,6 +38,9 @@ import javax.transaction.Transactional;
@Processes(User.class) @Processes(User.class)
public class UserImExporter extends AbstractEntityImExporter<User> { public class UserImExporter extends AbstractEntityImExporter<User> {
@Inject
private EntityManager entityManager;
@Inject @Inject
private UserRepository userRepository; private UserRepository userRepository;
@ -51,7 +55,8 @@ public class UserImExporter extends AbstractEntityImExporter<User> {
// Reset partyId. // Reset partyId.
entity.setPartyId(0); entity.setPartyId(0);
userRepository.save(entity); // userRepository.save(entity);
entityManager.persist(entity);
} }
@Override @Override

View File

@ -281,9 +281,11 @@ public class GroupImportTest {
@Test @Test
@UsingDataSet("datasets/org/libreccm/imexport/GroupImportTest/data.yml") @UsingDataSet("datasets/org/libreccm/imexport/GroupImportTest/data.yml")
@ShouldMatchDataSet(value = "datasets/org/libreccm/imexport/GroupImportTest" @ShouldMatchDataSet(
+ "/after-import-single-group.yml", excludeColumns = {"party_id"},
excludeColumns = {"party_id"} orderBy = {"groups.group_id", "parties.party_id"},
value = "datasets/org/libreccm/imexport/GroupImportTest"
+ "/after-import-single-group.yml"
) )
@InSequence(200) @InSequence(200)
public void importSingleGroup() { public void importSingleGroup() {

View File

@ -280,15 +280,18 @@ public class UserImportTest {
@Test @Test
@UsingDataSet("datasets/org/libreccm/imexport/UserImportTest/data.yml") @UsingDataSet("datasets/org/libreccm/imexport/UserImportTest/data.yml")
@ShouldMatchDataSet(value = "datasets/org/libreccm/imexport/UserImportTest" @ShouldMatchDataSet(
+ "/after-import-single-user.yml", excludeColumns = {"party_id"},
excludeColumns = {"party_id"} orderBy = {"users.user_id", "parties.party_id"},
value = "datasets/org/libreccm/imexport/UserImportTest"
+ "/after-import-single-user.yml"
) )
@InSequence(200) @InSequence(200)
public void importSingleUser() { public void importSingleUser() {
shiro.getSystemUser().execute(() -> shiro.getSystemUser().execute(()
importExport.importEntities("org.libreccm.imexport.UserImportTest") -> importExport.importEntities(
"org.libreccm.imexport.UserImportTest")
); );
} }

View File

@ -179,9 +179,11 @@ public class PermissionManagerTest {
@UsingDataSet( @UsingDataSet(
"datasets/org/libreccm/security/PermissionManagerTest/data.yml") "datasets/org/libreccm/security/PermissionManagerTest/data.yml")
@ShouldMatchDataSet( @ShouldMatchDataSet(
excludeColumns = {"permission_id", "uuid"},
orderBy = {"permissions.permission_id"},
value = "datasets/org/libreccm/security/PermissionManagerTest/" value = "datasets/org/libreccm/security/PermissionManagerTest/"
+ "after-grant.yml", + "after-grant.yml"
excludeColumns = {"permission_id"}) )
@InSequence(200) @InSequence(200)
public void grantPermission() { public void grantPermission() {
final Role role2 = roleRepository.findByName("role2").get(); final Role role2 = roleRepository.findByName("role2").get();
@ -226,9 +228,11 @@ public class PermissionManagerTest {
@UsingDataSet("datasets/org/libreccm/security/PermissionManagerTest/" @UsingDataSet("datasets/org/libreccm/security/PermissionManagerTest/"
+ "data-recursivly.yml") + "data-recursivly.yml")
@ShouldMatchDataSet( @ShouldMatchDataSet(
excludeColumns = {"permission_id", "uuid"},
orderBy = {"permissions.permission_id"},
value = "datasets/org/libreccm/security/PermissionManagerTest/" value = "datasets/org/libreccm/security/PermissionManagerTest/"
+ "after-grant-recursivly.yml", + "after-grant-recursivly.yml"
excludeColumns = {"permission_id"}) )
@InSequence(211) @InSequence(211)
public void grantPermissionRecursively() { public void grantPermissionRecursively() {
final Role role1 = roleRepository.findByName("role1").get(); final Role role1 = roleRepository.findByName("role1").get();
@ -688,7 +692,7 @@ public class PermissionManagerTest {
@ShouldMatchDataSet( @ShouldMatchDataSet(
value = "datasets/org/libreccm/security/PermissionManagerTest/" value = "datasets/org/libreccm/security/PermissionManagerTest/"
+ "after-copy.yml", + "after-copy.yml",
excludeColumns = {"permission_id"}) excludeColumns = {"permission_id", "uuid"})
@InSequence(400) @InSequence(400)
public void copyPermissions() throws Throwable { public void copyPermissions() throws Throwable {
final CcmObject object2 = ccmObjectRepository.findById(20002L).get(); final CcmObject object2 = ccmObjectRepository.findById(20002L).get();